Check primary runtime conflicts

[Knerio]

close #474
close #424

[github-actions]

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2170706240

Status: Passed
Duration: 3 minutes

Job summaries

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12164028726/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2170706240/test_report
Finished in 18.84 seconds (files took 11.03 seconds to load)
1206 examples, 0 failures
Line Coverage: 91.24% (4091 / 4484)
[TEST PROF INFO] Time spent in factories: 00:10.680 (42.31% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12164028724/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2170706240/test_report
Finished in 18.85 seconds (files took 11.63 seconds to load)
1159 examples, 0 failures
Line Coverage: 90.62% (3923 / 4329)
[TEST PROF INFO] Time spent in factories: 00:10.584 (42.16% of total time)

rubocop

682 files inspected, no offenses detected

[Knerio]

Somehow the jobs are causing a postgres connection leak but idk why, maybe @Taucher2003 can take a look

[Knerio]

@copilot Please take a look in the pipeline, it fails because the postgres connections are leaking because of the jobs, do you have an idea/solution why that happens

[Copilot]

@Knerio I've opened a new pull request, #683, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

Pull Request Overview

This PR implements runtime compatibility checking to validate that secondary runtimes are compatible with a project's primary runtime. It adds a compatible boolean field to track compatibility status and automatically updates it when runtime definitions change.

• Adds CheckRuntimeCompatibilityService to verify that runtimes have matching data types, flow types, and function definitions with compatible versions
• Implements UpdateRuntimeCompatibilityJob to asynchronously update compatibility status when runtime definitions change
• Updates FlowHandler to only send flows from compatible runtime assignments, removing the TODO comment

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
app/services/runtimes/check_runtime_compatibility_service.rb	New service that validates runtime compatibility by comparing versions and definitions between primary and secondary runtimes
app/jobs/update_runtime_compatibility_job.rb	New background job that executes compatibility checks and updates assignment records
app/models/namespace_project_runtime_assignment.rb	Adds compatible scope for filtering compatible assignments
db/migrate/20251109141754_add_is_compatible_to_primary_runtime.rb	Migration to add compatible boolean column with default false
db/structure.sql	Database schema updated with new compatible column
app/services/runtimes/data_types/update_service.rb	Triggers compatibility job when data types are updated
app/services/runtimes/flow_types/update_service.rb	Triggers compatibility job when flow types are updated
app/services/runtimes/runtime_function_definitions/update_service.rb	Triggers compatibility job when function definitions are updated
app/services/namespaces/projects/assign_runtimes_service.rb	Triggers compatibility job when runtimes are assigned to projects
app/services/error_code.rb	Adds three new error codes for compatibility validation failures
docs/graphql/enum/errorcodeenum.md	Documents the new error codes in GraphQL enum documentation
app/grpc/flow_handler.rb	Filters flows by compatible assignments and removes TODO comment
config/environments/test.rb	Configures test adapter for ActiveJob to prevent connection leaks
spec/services/runtimes/check_runtime_compatibility_service_spec.rb	Test coverage for the compatibility service
spec/jobs/update_runtime_compatibility_job_spec.rb	Test coverage for the compatibility job
db/schema_migrations/20251109141754	Migration checksum file

Comments suppressed due to low confidence (1)

docs/graphql/enum/errorcodeenum.md:30

• Duplicate error codes exist with similar meanings. Both NO_PRIMARY_RUNTIME (line 30) and MISSING_PRIMARY_RUNTIME (line 28) describe the absence of a primary runtime on a project. These should be consolidated into a single error code for consistency, or their descriptions should be updated to clarify the distinction if they represent different scenarios.

| `INVALID_FLOW_SETTING` | The flow setting is invalid because of active model errors |
| `INVALID_LOGIN_DATA` | Invalid login data provided |
| `INVALID_NAMESPACE_LICENSE` | The namespace license is invalid because of active model errors |

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.