feat(plugin-axe): implement core plugin functionality #1141

hanna-skryl · 2025-11-07T22:25:26Z

Implement Axe accessibility plugin with Playwright integration
Support WCAG 2.1/2.2, best practice, and all presets
Add comprehensive documentation and E2E tests

nx-cloud · 2025-11-07T22:26:54Z

View your CI Pipeline Execution ↗ for commit 6d66b16

Command	Status	Duration	Result
`nx code-pushup --nx-bail -- print-config --outp...`	❌ Failed	1m 41s	View ↗

☁️ Nx Cloud last updated this comment at 2025-11-08 00:37:19 UTC

pkg-pr-new · 2025-11-07T22:27:08Z

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1141

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1141

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1141

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1141

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1141

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1141

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1141

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1141

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1141

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1141

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1141

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1141

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1141

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1141

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1141

commit: 6d66b16

feat(plugin-axe): implement runner with Playwright/Axe integration

matejchalk

Very good overall 👍 I have some suggestions, but nothing major. I like that you were able to reuse a lot of logic and data types from the Lighthouse plugin.

matejchalk · 2025-11-10T09:50:11Z

packages/plugin-axe/project.json

The Axe plugin fails in CI.

Running Axe accessibility checks for 1 URL(s)...
Axe execution failed for https://github.com/code-pushup/cli?tab=readme-ov-file#code-pushup-cli/: browserType.launch: Executable doesn't exist at /home/runner/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell
╔═════════════════════════════════════════════════════════════════════════╗
║ Looks like Playwright Test or Playwright was just installed or updated. ║
║ Please run the following command to download new browsers: ║
║ ║
║ npx playwright install ║
║ ║
║ <3 Playwright Team ║
╚═════════════════════════════════════════════════════════════════════════╝
browserType.launch: Executable doesn't exist at /home/runner/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell
╔═════════════════════════════════════════════════════════════════════════╗
║ Looks like Playwright Test or Playwright was just installed or updated. ║
║ Please run the following command to download new browsers: ║
║ ║
║ npx playwright install ║
║ ║
║ <3 Playwright Team ║
╚═════════════════════════════════════════════════════════════════════════╝

I'm guessing running npx playwright install beforehand will fix the error.

I wonder if it would make sense for the plugin itself to run this command. 🤔 Or should we leave it up to the user? In my limited experience with Playwright, forgetting to run playwright install is a common mistake when adding E2E tests to CI. I'm not sure if it can be done in a cache-friendly way, though. Something like my ts-patch solution from #1133 would be ideal.

matejchalk · 2025-11-10T10:17:22Z

e2e/plugin-axe-e2e/vitest.e2e.config.ts

@@ -0,0 +1,5 @@
+import { createE2ETestConfig } from '../../testing/test-setup-config/src/index.js';
+
+export default createE2ETestConfig('ci-e2e', {


⚠️ The wrong project name is being used here.

Suggested change

export default createE2ETestConfig('ci-e2e', {

export default createE2ETestConfig('plugin-axe-e2e', {

packages/models/src/lib/plugin-config.ts

matejchalk · 2025-11-10T10:49:11Z

packages/models/src/lib/plugin-config.unit.test.ts

+  it('should throw for invalid URL', () => {
+    expect(() => pluginUrlsSchema.parse('not-a-url')).toThrow();
+  });
+
+  it('should throw for array with invalid URL', () => {
+    expect(() =>
+      pluginUrlsSchema.parse(['https://example.com', 'invalid']),
+    ).toThrow();
+  });


You could also test invalid weights and URLs in the object.

matejchalk · 2025-11-10T10:54:26Z

packages/plugin-axe/src/lib/meta/audits.unit.test.ts

+      const audit = transformRulesToAudits(
+        loadAxeRules('wcag21aa'),
+      )[0] as Audit;


Casting via non-null assertion is preferable, because it's safer (only strips null/undefined, while as T may ignore type mismatches than intended) and less verbose.

Suggested change

const audit = transformRulesToAudits(

loadAxeRules('wcag21aa'),

)[0] as Audit;

const audit = transformRulesToAudits(loadAxeRules('wcag21aa'))[0]!;

packages/plugin-axe/src/lib/runner/transform.ts

packages/plugin-axe/src/lib/axe-plugin.ts

matejchalk · 2025-11-10T12:18:46Z

packages/plugin-axe/README.md

+
+| Property       | Type        | Default      | Description                               |
+| -------------- | ----------- | ------------ | ----------------------------------------- |
+| `preset`       | `AxePreset` | `'wcag21aa'` | Accessibility ruleset preset              |


A link to the Preset details section would be useful here.

packages/utils/src/lib/reports/formatting.ts

hanna-skryl self-assigned this Nov 7, 2025

hanna-skryl added the 🧩 axe-plugin label Nov 7, 2025

github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 models 🧩 utils 🧩 lighthouse-plugin 🛠️ tooling labels Nov 7, 2025

hanna-skryl added 5 commits November 7, 2025 17:35

feat(plugin-axe): add plugin scaffolding

d89741a

feat(plugin-axe): add metadata transformations

44bc1af

feat(plugin-axe): add plugin configuration validation

f15817b

refactor(models,utils): extract shared URL utilities for plugins

4ba86c7

feat(plugin-axe): add audits and groups processing

d9d0a6e

hanna-skryl force-pushed the axe-plugin/core-functionality branch 2 times, most recently from 3680cce to e4e390f Compare November 7, 2025 22:57

github-actions bot added the 🦾 CI/CD Continuous integration and deployment label Nov 7, 2025

hanna-skryl force-pushed the axe-plugin/core-functionality branch from e4e390f to 72fc042 Compare November 7, 2025 23:36

github-actions bot removed the 🦾 CI/CD Continuous integration and deployment label Nov 7, 2025

hanna-skryl added 2 commits November 7, 2025 18:58

feat(plugin-axe): implement runner with Playwright/Axe integration

1281873

feat(plugin-axe): implement runner with Playwright/Axe integration

feat(utils,plugin-axe): improve report formatting

91e52de

hanna-skryl force-pushed the axe-plugin/core-functionality branch 2 times, most recently from c8c6dd5 to 972b3f1 Compare November 8, 2025 00:05

hanna-skryl added 5 commits November 7, 2025 19:17

test(plugin-axe): add E2E snapshot tests

6e6e304

feat(plugin-axe): add plugin setup

ecf9e21

docs(plugin-axe): add README and plugin metadata

066a1f5

refactor(plugin-axe): update to v0.85.0 and centralized test configs

6763a2a

refactor(plugin-axe): remove integration test config

6d66b16

hanna-skryl force-pushed the axe-plugin/core-functionality branch from 972b3f1 to 6d66b16 Compare November 8, 2025 00:17

hanna-skryl marked this pull request as ready for review November 8, 2025 00:56

hanna-skryl requested a review from BioPhoton as a code owner November 8, 2025 00:56

hanna-skryl requested review from matejchalk and vmasek November 8, 2025 00:57

matejchalk reviewed Nov 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(plugin-axe): implement core plugin functionality #1141

feat(plugin-axe): implement core plugin functionality #1141

hanna-skryl commented Nov 7, 2025

Uh oh!

nx-cloud bot commented Nov 7, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Nov 7, 2025 •

edited

Loading

Uh oh!

matejchalk left a comment

Uh oh!

matejchalk Nov 10, 2025

Uh oh!

matejchalk Nov 10, 2025

Uh oh!

Uh oh!

matejchalk Nov 10, 2025

Uh oh!

matejchalk Nov 10, 2025

Uh oh!

Uh oh!

Uh oh!

matejchalk Nov 10, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,5 @@
		import { createE2ETestConfig } from '../../testing/test-setup-config/src/index.js';

		export default createE2ETestConfig('ci-e2e', {

	export default createE2ETestConfig('ci-e2e', {
	export default createE2ETestConfig('plugin-axe-e2e', {

feat(plugin-axe): implement core plugin functionality #1141

Are you sure you want to change the base?

feat(plugin-axe): implement core plugin functionality #1141

Conversation

hanna-skryl commented Nov 7, 2025

Uh oh!

nx-cloud bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matejchalk left a comment

Choose a reason for hiding this comment

Uh oh!

matejchalk Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

matejchalk Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

matejchalk Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

matejchalk Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

matejchalk Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nx-cloud bot commented Nov 7, 2025 •

edited

Loading

pkg-pr-new bot commented Nov 7, 2025 •

edited

Loading