Skip to content

BREAKING CHANGE - Align content bucket name with url #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

BREAKING CHANGE - Align content bucket name with url #394

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
284a861
align content bucket name with url
cat5inthecradle May 24, 2023
0109700
rename bucket in old beta template
cat5inthecradle Jun 21, 2023
e96e35d
migrate content bucket permissions
cat5inthecradle Jun 21, 2023
1a34e99
update test to use more realistic url
cat5inthecradle Jun 21, 2023
c86e561
Merge branch 'main' of github.com:code-dot-org/javabuilder into jb394
cat5inthecradle Jun 21, 2023
0c1bb2e
Fix linting error in app stack
cat5inthecradle Jun 21, 2023
305801c
add capabilities to stack create
cat5inthecradle Jun 21, 2023
a15d8dc
add iam capability
cat5inthecradle Jun 21, 2023
3762862
fix json syntax
cat5inthecradle Jun 21, 2023
963f67d
try hardcoding role names
cat5inthecradle Jun 21, 2023
89b8d50
remove commented code
cat5inthecradle Jun 21, 2023
4fd6a56
add comment to failing template
cat5inthecradle Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cicd/3-app/javabuilder/template.yml.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ Resources:
ContentBucket:
Type: AWS::S3::Bucket
Properties:
BucketName: !If [IsDevCondition, !Sub "cdo-dev-${SubdomainName}-content", !Sub "cdo-${SubdomainName}-content"]
BucketName: !Sub "${SubdomainName}-content.${BaseDomainName}"
CorsConfiguration:
CorsRules:
- AllowedMethods: [GET, PUT]
Expand Down