lesson07 #330
Closed
lesson07 #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonydmays
requested changes
Mar 25, 2025
| */ | ||
| export function getFirstNFibonacciNumbers(n: number): number[] { | ||
| return []; | ||
| if (n <= 0) return []; |
| let end = values.length - 1; | ||
|
|
||
| const pivotIndex = Math.floor((start + end) / 2); // The index in the middle of the array. | ||
| while (start <= end) { |
Contributor
There was a problem hiding this comment.
This is the iterative way to do binary search. Good work doing your research.
| export function addNumbers(values: number[]): number { | ||
| return 0; | ||
| let sum= 0; | ||
| for (let i = 0; i < values.length; i++) { |
Contributor
There was a problem hiding this comment.
Fix indentation here and everywhere else.
anthonydmays
requested changes
Mar 25, 2025
Contributor
anthonydmays
left a comment
anthonydmays
left a comment
There was a problem hiding this comment.
Add the updated .env.test file as well.
Contributor
|
Closing this for now, feel free to re-open and continue work on it for an updated grade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mr. Mays,
This is my lesson07 work. It is not 100% completed. I have a meeting with Jordan this afternoon to go over syntax errors we discussed this morning.