feat/David.A_lesson7hw #326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Dadenaike251
commented
Mar 21, 2025
Dadenaike251
commented
- hw incomplete
…ike251/code-differently-25-q1 into release/David.A-lesson7hw
anthonydmays
requested changes
Mar 25, 2025
anthonydmays
requested changes
Mar 25, 2025
Contributor
There was a problem hiding this comment.
Your pull request names still don't meet the conventionalcommits.org standard.
Dadenaike251
commented
Mar 26, 2025
Contributor
Author
Dadenaike251
left a comment
Dadenaike251
left a comment
There was a problem hiding this comment.
This feature includes changes to my commit name and deletion of comment lines 43 - 52.
anthonydmays
requested changes
Mar 26, 2025
Contributor
anthonydmays
left a comment
anthonydmays
left a comment
There was a problem hiding this comment.
Your pull request names still don't meet the conventionalcommits.org standard. Going to close for now, feel free to re-open and address comments and I'll update your score.
| } | ||
| return[]; | ||
|
|
||
| // if (n === 0) { |
Contributor
There was a problem hiding this comment.
Must not have commented out code in your final PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.