feat: adds joseph_caballero_loader.ts and modifies loaders.module.ts for lesson_10 homework -Joseph Caballero #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for lesson_10 homework
…d to do exact seat: made changes to joseph_caballero_loader.ts -Joseph Caballero
Contributor
Author
made a new commit after learning as keyword, functionality is exactly the same i just wanted code to look better. |
…-24-q4 into feature/lesson10
anthonydmays
previously approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes lesson_10 homework by adding joseph_caballero_loader.ts and modifying loaders.module.ts:
For the added file I was able to do half of the extra credit. In that file I apply my own manual csv parsing but i was unable to get exactly 100 credits when i ran the test (I ended up with 200). This is due to my forEach loops being nested. I will be improving on my code more on my own but wanted to submit what I had before lecture to receive full credit.