Chigazo Lesson 07 #274
Closed
Chigazo Lesson 07 #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into code on l.31 l.33; used 'for-of' loop instead of 'for' loop on l.104;
…oved 'return array' if 'n = 0'; corrected formatting on binarySearch ;
anthonydmays
requested changes
Oct 11, 2024
| export function getFirstNFibonacciNumbers(n: number): number[] { | ||
| return []; | ||
|
|
||
| const array = [n] |
Contributor
There was a problem hiding this comment.
You probably don't want to put n here. If the function is called with 99, then the array will be initialized to [99] which is not what you want.
Contributor
Author
There was a problem hiding this comment.
changed to start the array as [1, 1] instead of [n]
|
|
||
| const array = [n] | ||
|
|
||
| for(let i = 2; i < n; i++){ |
Contributor
There was a problem hiding this comment.
What are you going to do if n === 1?
Contributor
Author
There was a problem hiding this comment.
added else-if condition for n === 1
Contributor
Author
There was a problem hiding this comment.
added to return [1]
added 11 commits
October 11, 2024 20:00
…atement for 'n==0';
anthonydmays
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.