-
Notifications
You must be signed in to change notification settings - Fork 477
Added deprecation note for WITH incremental_location = 'explicit_incrementals_URI #20952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
peachdawnleach
merged 10 commits into
main
from
20251103-doc-15327-deprecation-incremental
Nov 14, 2025
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
df951e6
Added deprecation note
peachdawnleach 7ab8c02
Adjusted warning and added to more pages
peachdawnleach ff9bc17
Merge branch 'main' into 20251103-doc-15327-deprecation-incremental
peachdawnleach 342d92e
Added to more files
peachdawnleach 6f70f5c
Moved to include
peachdawnleach 0caec78
Merge branch 'main' into 20251103-doc-15327-deprecation-incremental
peachdawnleach f6ada16
Rewording
peachdawnleach 1a99dab
Merge branch 'main' into 20251103-doc-15327-deprecation-incremental
peachdawnleach 280b3e0
Broken link
peachdawnleach 7eff910
Merge branch 'main' into 20251103-doc-15327-deprecation-incremental
peachdawnleach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
3 changes: 3 additions & 0 deletions
3
src/current/_includes/common/sql/incremental-location-warning.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| {{site.data.alerts.callout_danger}} | ||
| The `incremental_location` parameter is deprecated in versions 25.4 and later. If needed, you can continue to work with already existing backups that use a custom `incremental_location` , but this ability will be removed in version 26.2. | ||
| {{site.data.alerts.end}} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The precedent for deprecation notices is to be more vague, using the below wording (see style guide on this, though that part is about adding and not removing features). I would especially avoid citing v26.2 as the removal date could always change.
Not sure if I understood the change correctly, though. Is there any guidance we can offer on how to achieve this functionality by other means? Ideally a deprecation notice also conveys how we want the user to adjust.
(Also note style correction to cited versions.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, thanks for this- I'll check with @alicia-l2 and @msbutler to see if there's anything we want to add in terms of alternatives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From Michael- "There is no alternative way to achieve the same functionality via cockroach sql. That being said, the only use case for this option that we know of is to set fine grain ttl policies on full vs incremental backups, which the user can already do via their storage provider. i don't think we need to mention this though. If a customer bugs out, they can reach out, and we'll give them the workaround"