wip queuefeed skel #157081

asg0451 · 2025-11-07T20:15:51Z

No description provided.

blathers-crl · 2025-11-07T20:15:57Z

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

cockroach-teamcity · 2025-11-07T20:16:03Z

This change is

github-actions · 2025-11-07T21:47:10Z

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

github-actions · 2025-11-07T21:54:07Z

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

github-actions · 2025-11-07T21:56:45Z

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

Instead of returning a single array as json for the events stored in our queue, now return a row for each row so that we get root@127.0.0.1:26257/demoapp/movr> SELECT crdb_internal.select_from_queue_feed('foo', 3); crdb_internal.select_from_queue_feed ---------------------------------------- {"f1": "1", "f2": "2", "f3": "3"} {"f1": "4", "f2": "5", "f3": "6"} {"f1": "7", "f2": "8", "f3": "9"} instead of root@127.0.0.1:26257/demoapp/movr> SELECT crdb_internal.select_from_queue_feed('foo', 3); crdb_internal.select_from_queue_feed -------------------------------------------------------------------------------------------------------------------------------------------------------------- {"{\"f1\": \"1\", \"f2\": \"2\", \"f3\": \"3\"}","{\"f1\": \"11\", \"f2\": \"22\", \"f3\": \"33\"}","{\"f1\": \"111\", \"f2\": \"222\", \"f3\": \"333\"}"} (1 row)

Qf table based

github-actions · 2025-11-10T18:38:25Z

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

github-actions · 2025-11-10T19:11:13Z

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

add a table to track existing queues and add test

github-actions · 2025-11-10T21:24:21Z

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

blathers-crl · 2025-11-10T22:52:12Z

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

github-actions · 2025-11-10T22:56:31Z

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

rudimentary refresh assignment

github-actions · 2025-11-13T18:25:19Z

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

Epic: none

queuefeed checkpointing

Move reader mgmt to conn executor

watch all my partitions

Add a test for multiple ranges. Rewrite the span splitting logic so that it follows the pattern established by backup.

unassign dead sessions

github-actions · 2025-11-13T22:55:39Z

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

github-actions · 2025-11-14T02:06:35Z

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

Epic: none

queuefeed: support checkpoints per partition

add builtin for starting a changefeed from a cursor

Epic: none

create queuefeed from name

wip

ff6b2be

fix up and move stuff around

c2ba283

github-actions bot added the o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only. label Nov 7, 2025

asg0451 added 2 commits November 7, 2025 16:49

add oid entry

25c08d7

make qm

98dbecf

asg0451 and others added 5 commits November 8, 2025 17:13

working

b112ae6

rangefeed

c4ccf01

make sure it doesn't panic

9ecedaa

Merge pull request #3 from aerfrei/qf-table-based

302e890

Qf table based

queuefeed: add wrapper for partitions table

492de9e

aerfrei and others added 2 commits November 10, 2025 16:19

add a table to track existing queues and add test

e3703c3

Merge pull request #5 from aerfrei/qf-feeds-table

1bd941f

add a table to track existing queues and add test

aerfrei and others added 2 commits November 10, 2025 22:16

read from rangefeed

45e9f7f

Merge pull request #6 from asg0451/wip-queuefeed-rangefeed-and-stuff

bacc013

asg0451 added 5 commits November 11, 2025 03:01

fix build

1cba809

restore functionality

0824bcb

fix test

4cb10de

cleanup

cfc38aa

wip

d110c5d

asg0451 and others added 3 commits November 13, 2025 16:13

rudimentary reassignments

b5efef8

Merge pull request #17 from asg0451/refresh-assignment

e9e34da

rudimentary refresh assignment

Create a partition per range

d4da061

aerfrei and others added 11 commits November 13, 2025 14:10

queuefeed: Add checkpointing logic

9188113

Epic: none

Merge pull request #14 from aerfrei/qf-cursor

781a98d

queuefeed checkpointing

move reader management to conn executor

d5ab9c3

cleanup

229ee22

Merge pull request #20 from asg0451/move-connex

6cab99a

Move reader mgmt to conn executor

fix test

e08acd2

watch all my partitions

8e41ad4

Merge pull request #23 from asg0451/watch-all-parts

a55880a

watch all my partitions

queuefeed: add smoke test with multiple partitions

4f5a5b7

Add a test for multiple ranges. Rewrite the span splitting logic so that it follows the pattern established by backup.

unassign dead sessions

623d774

Merge pull request #25 from asg0451/reset-unalive-assignments

7042e71

unassign dead sessions

jeffswenson added 2 commits November 13, 2025 20:16

queuefeed: call close on manager in tests

cd24183

queuefeed: wire up partition cache to the assigner

b36402a

aerfrei and others added 10 commits November 14, 2025 10:08

queuefeed: support partitions in checkpointing

3d5df16

Epic: none

queuefeed: use frontier for tracking partition progress

f84b7f7

Epic: none

queuefeed: set the cursor to the queue creation time on creation

516bd9b

Epic: none

Merge pull request #24 from aerfrei/qf-partition-checkpointing-support

3092a4a

queuefeed: support checkpoints per partition

add builtin for starting a changefeed from a cursor

8642c18

Merge pull request #28 from aerfrei/qf-cursor-builtin

789c7c1

add builtin for starting a changefeed from a cursor

queuefeed: create a multi-reader smoke test

255443b

queuefeed: create queuefeed from table name

9b9c860

Epic: none

Merge pull request #29 from aerfrei/qf-builtin-to-take-table-name

c3c433a

create queuefeed from name

roachtest: add queuefeed roachtest

4288fab

cockroach-teamcity added the X-perf-gain Microbenchmarks CI: Added if a performance gain is detected label Nov 14, 2025

wip queuefeed skel #157081

Are you sure you want to change the base?

wip queuefeed skel #157081

Conversation

asg0451 commented Nov 7, 2025

Uh oh!

blathers-crl bot commented Nov 7, 2025

Uh oh!

cockroach-teamcity commented Nov 7, 2025

Uh oh!

github-actions bot commented Nov 7, 2025

Potential Bug(s) Detected

Uh oh!

github-actions bot commented Nov 7, 2025

Potential Bug(s) Detected

Uh oh!

github-actions bot commented Nov 7, 2025

Potential Bug(s) Detected

Uh oh!

github-actions bot commented Nov 10, 2025

Potential Bug(s) Detected

Uh oh!

github-actions bot commented Nov 10, 2025

Potential Bug(s) Detected

Uh oh!

github-actions bot commented Nov 10, 2025

Potential Bug(s) Detected

Uh oh!

blathers-crl bot commented Nov 10, 2025

Uh oh!

github-actions bot commented Nov 10, 2025

Potential Bug(s) Detected

Uh oh!

github-actions bot commented Nov 13, 2025

Potential Bug(s) Detected

Uh oh!

github-actions bot commented Nov 13, 2025

Potential Bug(s) Detected

Uh oh!

github-actions bot commented Nov 14, 2025

Potential Bug(s) Detected

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants