workload: validate bank rows flag #157050
Draft
+118
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if a value of 1 was passed in for rows, the workload would panic. We need at least two accounts to be able to do transfers. This change ensures we validate the flag. Fixes: cockroachdb#153849
Member
|
This change is |
herkolategan
force-pushed
the
hbl/workload-row-validation-unit-tests
branch
3 times, most recently
from
4fc9159 to
53cc189
Compare
The validation added in the bank workload now requires at least two rows for validation to pass. This change updates the unit tests to pass at least 2 accounts.
herkolategan
force-pushed
the
hbl/workload-row-validation-unit-tests
branch
from
53cc189 to
4779e11
Compare
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
github-actions
bot
added
the
o-AI-Review-Potential-Issue-Detected
Previously, the logic in the bank `Ops` function tried to work around the fact that the number of rows (accounts) might be 0 or 1. This logic didn't seem right, as the `to` bank account was never allowed to be on the tail end. This change uses the condition enforced by the validation that we always expect rows to be at least 2. This allows us to simplify the from and to selection here, which is not allowed to point to the same account.
herkolategan
commented
Nov 10, 2025
| // Rows are always expected to be at least two (via validation). | ||
| from := rng.IntN(b.rows) | ||
| to := rng.IntN(b.rows - 1) | ||
| for from == to && b.rows != 1 { |
Collaborator
Author
There was a problem hiding this comment.
Potential Bug(s) Detected
If we have 2 rows (allowed), this could potentially indefinitely loop.
Both from and to select 0, hence from == to and b.rows != 1 (= 2).
And b.rows - 1 = 1 resulting in to staying 0 during the loop, resulting in an indefinite loop.
With a minimum of 2 rows now being validated we can update this logic to account for that.
herkolategan
removed
the
o-AI-Review-Potential-Issue-Detected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a value of 1 was passed in for rows, the workload would panic. We
need at least two accounts to be able to do transfers. This change ensures we
validate the flag.
Fixes: #153849