Skip to content

Conversation

@bghal
Copy link
Contributor

@bghal bghal commented Nov 6, 2025

TODO:

Fixes: #142914
Epic: CRDB-31283

Release note (sql change): The ALTER COLUMN ... sequence identity
commands are run by the declarative schema changer.

@blathers-crl
Copy link

blathers-crl bot commented Nov 6, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@bghal bghal force-pushed the sc-column-sequence-identity branch 2 times, most recently from 5fb6b01 to 95ba509 Compare November 7, 2025 19:37
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@github-actions github-actions bot added the o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only. label Nov 7, 2025
This operation covers a single option not multiple.

Part of: cockroachdb#142914
Epic: CRDB-31283

Release note: None
TODO:

Fixes: cockroachdb#142914
Epic: CRDB-31283

Release note (sql change): The `ALTER COLUMN ...` sequence identity
commands are run by the declarative schema changer.
@bghal bghal force-pushed the sc-column-sequence-identity branch from 95ba509 to f9aa939 Compare November 10, 2025 20:30
@github-actions
Copy link

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql/schemachanger: support ALTER COLUMN ... [RESTART | SET [CACHE | CYCLE | ... ] in declarative schema changer

2 participants