-
Notifications
You must be signed in to change notification settings - Fork 4k
kvserver, storage: add bytes compressed/decompressed metrics #157008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
5bfbbf8 to
c73e1b3
Compare
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
c73e1b3 to
7c56a8b
Compare
sumeerbhola
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumeerbhola reviewed 1 of 3 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @DarrylWong and @shailendra-patel)
pkg/kv/kvserver/metrics.go line 1239 at r1 (raw file):
Unit: metric.Unit_CONST, } metaBytesCompressedL5Data = metric.Metadata{
how about using static label metrics for these metrics https://docs.google.com/document/d/1fn5KX0uPUCw1uW4KkCvmP9-svga0F6XSvhnqdg24MpE/edit?tab=t.0#heading=h.9ndo02nsmu? Should allow us to define 1 metric with {compresssed,decompressed}x{l5,l6}x{data,values}.
|
Previously, sumeerbhola wrote…
Oooh, forgot about that. Great idea, I will work on that! |
The motivation for these metrics is to enable estimating the CPU usage impact of switching to a stronger compression method (which applies only to L5/L6 data/value blocks). Epic: none Release note: None
7c56a8b to
aedf482
Compare
RaduBerinde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @aa-joshi, @Abhinav1299, @alyshanjahani-crl, @arjunmahishi, @DarrylWong, @shailendra-patel, and @sumeerbhola)
pkg/kv/kvserver/metrics.go line 1239 at r1 (raw file):
Previously, RaduBerinde wrote…
Oooh, forgot about that. Great idea, I will work on that!
Done.
sumeerbhola
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumeerbhola reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @aa-joshi, @Abhinav1299, @alyshanjahani-crl, @arjunmahishi, @DarrylWong, and @shailendra-patel)
Metrics change detectedThis PR adds or updates one or more CRDB metrics. If you want these metrics to be exported by CRDB Cloud clusters to Internal CRL Datadog and/or included in the customer metric export integration (Essential metrics for standard deployment, and Essential metrics for advanced deployment), refer to this Installation and Usage guide of a CLI tool that syncs the metric mappings in managed-service. Run this CLI tool after your CRDB PR is merged.
Note: Your metric will appear in Internal CRL Datadog only after the managed-service PR merges and the new OTel configuration rolls out to at least one cluster running a CRDB build that includes this metric. Docs: cockroach-metric-sync Questions: reach out to @obs-india-prs |
|
TFTR! bors r+ |
|
Build succeeded: |
The motivation for these metrics is to enable estimating the CPU usage
impact of switching to a stronger compression method (which applies
only to L5/L6 data/value blocks).
Epic: none
Release note: None