Skip to content

Conversation

@RaduBerinde
Copy link
Member

The motivation for these metrics is to enable estimating the CPU usage
impact of switching to a stronger compression method (which applies
only to L5/L6 data/value blocks).

Epic: none
Release note: None

@RaduBerinde RaduBerinde requested review from a team and sumeerbhola November 6, 2025 15:45
@RaduBerinde RaduBerinde requested a review from a team as a code owner November 6, 2025 15:45
@blathers-crl
Copy link

blathers-crl bot commented Nov 6, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@github-actions github-actions bot added the o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only. label Nov 7, 2025
@RaduBerinde RaduBerinde added the O-AI-Review-Real-Issue-Found AI reviewer found real issue label Nov 7, 2025
@RaduBerinde RaduBerinde requested a review from a team as a code owner November 7, 2025 15:26
@RaduBerinde RaduBerinde requested review from DarrylWong and shailendra-patel and removed request for a team November 7, 2025 15:26
Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumeerbhola reviewed 1 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @DarrylWong and @shailendra-patel)


pkg/kv/kvserver/metrics.go line 1239 at r1 (raw file):

		Unit:        metric.Unit_CONST,
	}
	metaBytesCompressedL5Data = metric.Metadata{

how about using static label metrics for these metrics https://docs.google.com/document/d/1fn5KX0uPUCw1uW4KkCvmP9-svga0F6XSvhnqdg24MpE/edit?tab=t.0#heading=h.9ndo02nsmu? Should allow us to define 1 metric with {compresssed,decompressed}x{l5,l6}x{data,values}.

@RaduBerinde
Copy link
Member Author

pkg/kv/kvserver/metrics.go line 1239 at r1 (raw file):

Previously, sumeerbhola wrote…

how about using static label metrics for these metrics https://docs.google.com/document/d/1fn5KX0uPUCw1uW4KkCvmP9-svga0F6XSvhnqdg24MpE/edit?tab=t.0#heading=h.9ndo02nsmu? Should allow us to define 1 metric with {compresssed,decompressed}x{l5,l6}x{data,values}.

Oooh, forgot about that. Great idea, I will work on that!

The motivation for these metrics is to enable estimating the CPU usage
impact of switching to a stronger compression method (which applies
only to L5/L6 data/value blocks).

Epic: none
Release note: None
@RaduBerinde RaduBerinde requested review from a team as code owners November 13, 2025 02:26
@RaduBerinde RaduBerinde requested review from Abhinav1299, aa-joshi, alyshanjahani-crl and arjunmahishi and removed request for a team November 13, 2025 02:26
Copy link
Member Author

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @aa-joshi, @Abhinav1299, @alyshanjahani-crl, @arjunmahishi, @DarrylWong, @shailendra-patel, and @sumeerbhola)


pkg/kv/kvserver/metrics.go line 1239 at r1 (raw file):

Previously, RaduBerinde wrote…

Oooh, forgot about that. Great idea, I will work on that!

Done.

Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@sumeerbhola reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @aa-joshi, @Abhinav1299, @alyshanjahani-crl, @arjunmahishi, @DarrylWong, and @shailendra-patel)

@blathers-crl
Copy link

blathers-crl bot commented Nov 13, 2025

Metrics change detected

This PR adds or updates one or more CRDB metrics. If you want these metrics to be exported by CRDB Cloud clusters to Internal CRL Datadog and/or included in the customer metric export integration (Essential metrics for standard deployment, and Essential metrics for advanced deployment), refer to this Installation and Usage guide of a CLI tool that syncs the metric mappings in managed-service. Run this CLI tool after your CRDB PR is merged.

  • The CLI opens a PR in managed-service with the required config changes.
  • Please track that PR and ensure it merges so your metrics become available to CRDB Cloud clusters.

Note: Your metric will appear in Internal CRL Datadog only after the managed-service PR merges and the new OTel configuration rolls out to at least one cluster running a CRDB build that includes this metric.

Docs: cockroach-metric-sync

Questions: reach out to @obs-india-prs

@RaduBerinde
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 13, 2025

@craig craig bot merged commit 275290a into cockroachdb:master Nov 13, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only. O-AI-Review-Real-Issue-Found AI reviewer found real issue target-release-26.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants