Skip to content

Fix video error due to unsupported 'auto' streaming profile #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix video error due to unsupported 'auto' streaming profile #138

wants to merge 1 commit into from

Conversation

@rzats
Copy link

@rzats rzats commented Oct 24, 2025

Description

Fixes an error with CldVideoPlayer described in the attached issue. This detects when streaming_profile: 'auto' is used and removes the conflicting quality parameter.

(This is only one possible solution and ideas for an alternate fix are welcome!)

Here's a demo page which replicates the error with the latest version of the SDK, but works with my change applied:

---
import { CldVideoPlayer } from 'astro-cloudinary';
---

<html lang="en">
	<head>
		<meta charset="utf-8" />
		<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
		<meta name="viewport" content="width=device-width" />
		<meta name="generator" content={Astro.generator} />
		<title>Astro Cloudinary Test - Issue #32</title>
	</head>
	<body>
		<main>
			<h1>Testing CldVideoPlayer with streaming_profile: 'auto'</h1>

			<div style="margin: 20px 0;">
				<h2>This should work (streaming_profile: 'hd'):</h2>
				<CldVideoPlayer
					src="samples/sea-turtle"
					width="1920"
					height="1080"
					sourceTypes={['hls']}
					transformation={{
						streaming_profile: 'hd',
					}}
				/>
			</div>

			<div style="margin: 20px 0;">
				<h2>This should fail (streaming_profile: 'auto'):</h2>
				<CldVideoPlayer
					src="samples/sea-turtle"
					width="1920"
					height="1080"
					sourceTypes={['hls']}
					transformation={{
						streaming_profile: 'auto',
					}}
				/>
			</div>
		</main>
	</body>
</html>

Issue Ticket Number

Fixes #32

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR - I fixed an existing issue instead!
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass - or rather manually tested the bugfix
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation - it's a bugfix so this is not needed

@vercel
Copy link

vercel bot commented Oct 24, 2025

@rzats is attempting to deploy a commit to the Cloudinary DevX Team on Vercel.

A member of the Team first needs to authorize it.

@devpatocld
Copy link
Collaborator

devpatocld commented Oct 28, 2025

@rzats your PR is under review

@rzats
Copy link
Author

rzats commented Oct 30, 2025

@devpatocld hello! Since Hacktoberfest is wrapping up, checking if this PR is gonna be eligible for the swag kit since it's currently in review. I'm available to make changes if needed. Thank you :)

@eportis-cloudinary
Copy link
Contributor

eportis-cloudinary commented Nov 15, 2025

Hi @rzats ! Thank you so much for your thoughtful and constructive contribution, and we are very sorry for the extended delay in review. I do think we actually want to handle this at a lower level (in cloudinary-util), so that the fix can be easily picked up by all of the other community libraries. Ideally I would have been able to give you that feedback a few weeks ago! I am going to give this the -accepted label and my colleague @devpatocld will reach out about Hacktoberfest swag. I should have some time in December to use the code you wrote here as a template for fixing the issue in cloudinary-util. Of course, if you are still game to contribute further, feel free to beat me to the punch – but because of holidays and vacation I won't be able to review any further contributions until then.

@rzats
Copy link
Author

rzats commented Nov 16, 2025

@eportis-cloudinary @devpatocld that's great to know, thanks! I'll look into the alternate fix as well 👌

@devpatocld
Copy link
Collaborator

devpatocld commented Nov 18, 2025

@rzats Thanks so much for your contribution! I have sent you an email with a form for you to claim your swag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eportis-cloudinary eportis-cloudinary Awaiting requested review from eportis-cloudinary

Assignees

No one assigned

Labels

hacktoberfest hacktoberfest2025 hacktoberfest-accepted hacktoberfest-WIP swag-invitation-sent

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] CldVideoPlayer - sp_auto is not supported due to quality parameter

3 participants

@rzats @devpatocld @eportis-cloudinary