Skip to content

unify (cljs.repl/doc ...) handling of js/console #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2025
+8 −7
Merged

unify (cljs.repl/doc ...) handling of js/console #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/main/clojure/cljs/repl.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1452,20 +1452,21 @@ itself (not its value) is returned. The reader macro #'x expands to (var x)."}})
(keyword? name)
`(cljs.repl/print-doc {:spec ~name :doc (cljs.spec.alpha/describe ~name)})

(= "js" (namespace name))
`(cljs.repl/print-doc
(quote ~(merge (select-keys (ana-api/resolve-extern name) [:doc :arglists])
{:name name})))

(ana-api/find-ns name)
`(cljs.repl/print-doc
(quote ~(select-keys (ana-api/find-ns name) [:name :doc])))

(ana-api/resolve &env name)
`(cljs.repl/print-doc
(quote ~(let [var (ana-api/resolve &env name)
m (select-keys var
[:ns :name :doc :forms :arglists :macro :url])]
ns (-> var :name namespace)
m (cond-> var
(= "js" ns)
(-> :name ana-api/resolve-extern
(select-keys [:doc :arglists])
(merge {:name name}))
(not= "js" ns)
(select-keys [:ns :name :doc :forms :arglists :macro :url]))]
(cond-> (update-in m [:name] clojure.core/name)
(:protocol-symbol var)
(assoc :protocol true
Expand Down