Disable scheduling procedures #3768
Merged
+58
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Update: we ended up reverting 3704 |
jdetter
approved these changes
Nov 26, 2025
Collaborator
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
Seems fine, we ended up reverting 3704. I have not tested this myself but the change looks fine 👍
Contributor
Author
|
I have confirmed with @coolreader18 that we don't need any changes related to TypeScript modules; the ModuleDef validator is sufficient. |
…orklabs/SpacetimeDB into phoebe/procedure/disable-schedule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
We've been unable to get scheduled procedures into the initial release of procedures due to a nondeterministic hang in some of our tests which we don't have time to debug. As such, this commit disables scheduled procedures by:
RawModuleDevV9validator to reject scheduled procedures.API and ABI breaking changes
N/a
Expected complexity level and risk
1
Testing
Automated tests should be sufficient.
Prior to merging #3774 , CI for this branch merged with master failed in the intended way: modules which attempted to define scheduled procedures failed to typecheck.