Skip to content

Print internal error when a procedure call fails in sdk test client #3725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 24, 2025
Merged

Print internal error when a procedure call fails in sdk test client #3725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33baaa7
Print internal error when a procedure call fails in sdk test client
gefjon Nov 21, 2025
fa0ab15
Also log warning with `log` when kicking clients for channel capacity
gefjon Nov 21, 2025
9b32123
Merge branch 'master' into phoebe/procedure/additional-logging-in-tests
gefjon Nov 24, 2025
0ec710c
Merge branch 'master' into phoebe/procedure/additional-logging-in-tests
gefjon Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/core/src/client/client_connection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,11 @@ impl ClientConnectionSender {
confirmed_reads = self.config.confirmed_reads,
"client channel capacity exceeded"
);
log::warn!(
"Client {:?} exceeded channel capacity of {}, kicking",
self.id,
self.sendtx.capacity(),
);
self.abort_handle.abort();
self.cancelled.store(true, Ordering::Relaxed);
return Err(ClientSendError::Cancelled);
Expand Down
8 changes: 4 additions & 4 deletions sdks/rust/tests/procedure-client/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ fn exec_insert_with_tx_commit() {
sub_applied_nothing_result(assert_all_tables_empty(ctx));

ctx.procedures.insert_with_tx_commit_then(move |ctx, res| {
assert!(res.is_ok());
assert!(res.is_ok(), "Expected Ok result but got {res:?}");
let row = ctx.db().my_table().iter().next().unwrap();
assert_eq!(row.field, expected());
inspect_result(Ok(()));
Expand All @@ -237,7 +237,7 @@ fn exec_insert_with_tx_rollback() {
sub_applied_nothing_result(assert_all_tables_empty(ctx));

ctx.procedures.insert_with_tx_rollback_then(move |ctx, res| {
assert!(res.is_ok());
assert!(res.is_ok(), "Expected Ok result but got {res:?}");
assert_eq!(ctx.db().my_table().iter().next(), None);
inspect_result(Ok(()));
});
Expand All @@ -264,7 +264,7 @@ fn exec_procedure_http_ok() {
// It's a try block!
#[allow(clippy::redundant_closure_call)]
(|| {
anyhow::ensure!(res.is_ok());
anyhow::ensure!(res.is_ok(), "Expected Ok result but got {res:?}");
let module_def: RawModuleDefV9 = spacetimedb_lib::de::serde::deserialize_from(
&mut serde_json::Deserializer::from_str(&res.unwrap()),
)?;
Expand Down Expand Up @@ -300,7 +300,7 @@ fn exec_procedure_http_err() {
// It's a try block!
#[allow(clippy::redundant_closure_call)]
(|| {
anyhow::ensure!(res.is_ok());
anyhow::ensure!(res.is_ok(), "Expected Ok result but got {res:?}");
let error = res.unwrap();
anyhow::ensure!(error.contains("error"));
anyhow::ensure!(error.contains("http://foo.invalid/"));
Expand Down
Loading