Add terminal mode navigation support with FZF compatibility fix for issue #430 #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I also checked up on #172 to make sure that nothing would actually break. When vim-FZF is detected vim-tmux-navigator behavious is stopped and keys are instead passed straight to vim-FZF, you need to then exit vim-FZF to go back to business as usual. |
francescoVaglienti
changed the title
Owner
|
Thanks for the detailed summary and update here, @francescoVaglienti. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current tmux-navigator plugin doesn't handle terminal mode (term) navigation seamlessly. When using terminal splits in Vim alongside tmux panes, the navigation breaks down. This functionality had been left out because it collided with Vim FZF
Solution
Added terminal mode support with FZF-awareness:
New terminal mode mappings that integrate with existing tmux navigation
Added IsFZF() function to detect when we're in FZF
Used mappings to conditionally pass through controls to FZF when appropriate