Issue #124: Implement recipe for NewlineAtEndOfFile #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anmol202005
force-pushed
the
eol
branch
15 times, most recently
from
8b311bc to
e5cc5a3
Compare
Collaborator
Author
|
Finally got CI GREEN. @rdiachenko pls review :) |
Collaborator
Author
|
@romani @rdiachenko ping. |
romani
requested changes
Nov 9, 2025
src/main/java/org/checkstyle/autofix/recipe/NewlineAtEndOfFile.java
Outdated
Show resolved
Hide resolved
src/main/java/org/checkstyle/autofix/recipe/NewlineAtEndOfFile.java
Outdated
Show resolved
Hide resolved
src/main/java/org/checkstyle/autofix/recipe/NewlineAtEndOfFile.java
Outdated
Show resolved
Hide resolved
| final Space eof = sourceFile.getEof(); | ||
| final String lastWhitespace = eof.getLastWhitespace(); | ||
|
|
||
| if (!lineEnding.equals(lastWhitespace)) { |
Member
There was a problem hiding this comment.
we do not trust checkstyle violation ? or it is save check in case of second execution.
Collaborator
Author
There was a problem hiding this comment.
this is a check for second execution.
src/main/java/org/checkstyle/autofix/recipe/NewlineAtEndOfFile.java
Outdated
Show resolved
Hide resolved
romani
requested changes
Nov 14, 2025
| if (!expectedLineEnding.equals(lastWhitespace)) { | ||
| final List<Comment> comments = eof.getComments(); | ||
| if (comments.isEmpty()) { | ||
| result = sourceFile.withEof(Space.format(expectedLineEnding)); |
Member
There was a problem hiding this comment.
does it check comments at the end of file ?
if yes, we do not have test input for this, please add.
if no, please share details with me, I need you help here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #124
Implemented recipe for NewlineAtEndOfFile: https://checkstyle.sourceforge.io/checks/misc/newlineatendoffile.html