Skip to content

test(rpc-client): test_qr_securejoin_broadcast: Wait for CHATLIST_CHANGED before getting chatlist #7437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test(rpc-client): test_qr_securejoin_broadcast: Wait for CHATLIST_CHANGED before getting chatlist #7437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions deltachat-rpc-client/tests/test_securejoin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ def check_account(ac, contact, inviter_side, please_wait_info_msg=False):
# Start second Bob device, if it wasn't started already.
bob2.start_io()
bob2.wait_for_securejoin_joiner_success()
bob2.wait_for_event(EventType.CHATLIST_CHANGED)
Copy link
Collaborator Author

@iequidoo iequidoo Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that this is only needed for the bob2 device, the reason is that events arrive in another order on the second device. But i'm not sure it's worth complicating the test and trying to wait for this event for the first device somehow. Maybe it's better then to fix Core and emit CHATLIST_CHANGED one more time after SecureJoin finishes

Copy link
Collaborator

@Hocuri Hocuri Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring out the problem!

We can probably move the call to get_broadcast() down a bit? I made an alternative PR: #7442

wait_for_broadcast_messages(bob2)
check_account(bob2, bob2.create_contact(alice), inviter_side=False)

Expand Down
Loading