ENT-13535: Added packages promiser sanitation (3.21.x) #5974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cf-bottom Jenkins with exotics please :) |
|
Sure, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/13103/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13103/ |
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech> (cherry picked from commit ef1f52a)
I also refactored the code to use a dynamic buffer when assembling the commands. Estimating the buffer size needed is error prone and can quickly lead to buffer overflows. Ticket: ENT-13535 Changelog: Title Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech> (cherry picked from commit aaf314a)
larsewi
force-pushed
the
packages-3.21.x
branch
from
8ea8c43 to
e91200b
Compare
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13122/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13122/ |
… quoting arguments Ticket: ENT-13535 Changelog: none (cherry picked from commit 6f97d0a) Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13147/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13147/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: ENT-13535
Signed-off-by: Lars Erik Wik lars.erik.wik@northern.tech
(cherry picked from commit e865642)
Backported from #5967