fix: cvoverflowmenu focus #1800
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilherme-gm
requested changes
Dec 4, 2025
Contributor
guilherme-gm
left a comment
guilherme-gm
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
From my tests, while this solves the original issue of not closing the menu, it breaks the accessibility of the component.
Since the focus is now moved to the menu element instead of the items, a keyboard user is no longer able to navigate through the menu items.
Example: (original code)
- Press tab to select the menu
- Press Enter --> Menu is open, first element targeted
- Press Tab --> Next element targeted
- Press ESC --> Menu gets closed
on new code, we can only focus the entire menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #
What did you do?
Fixing Cv-Overflow-Menu focus issue.
Why did you do it?
When the first element was disabled then the focus was on a different element not on the menu
How have you tested it?
User test
Were docs updated if needed?
N/A