-
Notifications
You must be signed in to change notification settings - Fork 139
[Java] Document references #2153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 13 commits
e0c19c6
3cfdad1
36fbf31
801631e
caa3892
b1a24dd
92a0ac3
f295189
0f14609
fb7591f
7a5c3c3
5d740ce
4a67d72
2e7d155
51b74cd
91b2f00
5002237
1b1f731
881693f
278e74a
46ecab7
b47d480
761a620
483e0a9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -131,7 +131,6 @@ In the [CDS Query Language (CQL)](/cds/cql) builder, the lambda expression `o -> | |||||
| To target components of a structured document, we recommend using path expressions with infix filters. | ||||||
| ::: | ||||||
|
|
||||||
|
|
||||||
| ### Filters {#target-entity-filters} | ||||||
|
|
||||||
| Besides using infix filters in path expressions, the `Select`, `Update`, and `Delete` builders support filtering the [target entity set](#target-entity-sets) via the `where` method. Using `where` is equivalent to defining an infix filter on the last segment of a path expression in the statement's `from` / `entity` clause. For statements that have both, an infix filter on the last path segment and a `where` filter, the resulting target filter is the conjunction (`and`) of the infix filter and the `where` filter. | ||||||
|
|
@@ -1309,11 +1308,67 @@ The Query Builder API supports using expressions in many places. Expressions con | |||||
|
|
||||||
| ### Entity References {#entity-refs} | ||||||
|
|
||||||
| Entity references specify entity sets. They can be used to define the target entity set of a [CQL](../../cds/cql) statement. They can either be defined inline using lambda expressions in the Query Builder (see [Target Entity Sets](#target-entity-sets)) or via the `CQL.entity` method, which is available in an _untyped_ version as well as in a _typed_ version that uses the generated [model interfaces](../cqn-services/persistence-services#model-interfaces). The following example shows an entity reference describing the set of *authors* that have published books in the year 2020: | ||||||
| Entity references specify entity sets and can define the target entity set of a [CQL](../../cds/cql) statement or serve as an argument for event handlers. | ||||||
|
||||||
|
|
||||||
| A reference consists of _segments_ that define the path from the entity's root to a certain part of it. Each segment has the _identifier_ with the name of the entity or an element and an optional filter _predicate_. These predicates might include other references. The references are not bound to the particular model and are not checked against it while they are being built. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use active voice instead of passive voice. Change 'References are not bound to the particular model and are not checked against it while they are being built' to 'The system does not bind references to a particular model and does not check them against it during construction.'
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use present tense instead of future tense. The phrase "are not checked against it while they are being built" should be "are not checked against it during construction" to maintain present tense throughout. Suggested revision:
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This sentence uses passive voice and is unclear. Consider revising to: "The system does not bind references to a particular model and does not check them against it while building them." |
||||||
|
|
||||||
| References are either _absolute_ or _relative_. Absolute references always have the fully qualified name of the type in their first segment. | ||||||
|
||||||
|
|
||||||
| The simplest kind of absolute reference is a reference to the entity set, for example, to all books. | ||||||
|
|
||||||
| ```java | ||||||
| import com.sap.cds.ql.CQL; | ||||||
| Books_ books = CQL.entity(Books_.class); // {"ref":["sap.capire.bookshop.Books"]} | ||||||
|
|
||||||
| StructuredTypeRef ref = bookWithId.asRef(); // or CqnStructuredTypeRef which is a cleaner equivalent type | ||||||
| ``` | ||||||
|
|
||||||
| The method `asRef()` seals the reference and makes it immutable. | ||||||
|
|
||||||
| Relative references point to the elements of the entity, for example, the title of a book, where the type is known in advance or specified elsewhere. In CQL statements, relative references are members of its select list and relate to the statement source that is an absolute reference. | ||||||
|
|
||||||
| ```java | ||||||
| CqnElementRef title = CQL.entity(Books_.class).title(); // {"ref":["title"]} | ||||||
| CqnElementRef dynamicTitle = CQL.get(Books.TITLE); // {"ref":["title"]} | ||||||
| ``` | ||||||
|
|
||||||
| New references are constructed with [model interfaces](../cqn-services/persistence-services#model-interfaces) or via API that is also used to build [CQL statements](/java/working-with-cql/query-api#concepts). For most of application code, the model interfaces are the recommended way to do this. | ||||||
|
||||||
|
|
||||||
| References with multiple segments represent navigation within a structured entity or between different entities via its associations. For example, the following is a reference that represents the path from the book to its chapters. | ||||||
|
|
||||||
| ```java | ||||||
| CqnStructuredTypeRef ref = CQL.entity(Books_.class).filter(b -> b.ID().eq("...")).chapters(c -> c.ID().eq("...")).pages(p -> p.ID().eq("...")).asRef(); | ||||||
| ``` | ||||||
|
|
||||||
| References can be represented as JSON following an [Expression](../../cds/cxn) notation. The following is the JSON representation of the reference above: | ||||||
|
||||||
|
|
||||||
| ```json | ||||||
| { | ||||||
| "ref": [ | ||||||
| { | ||||||
| "id": "sap.capire.bookshop.Books", | ||||||
| "where": [ | ||||||
| { "ref": ["ID"]}, "=", {"val": "..."} | ||||||
| ] | ||||||
| }, | ||||||
| { | ||||||
| "id": "chapters", | ||||||
| "where": [ | ||||||
| { "ref": ["ID"]}, "=", {"val": "..."} | ||||||
| ] | ||||||
| }, | ||||||
| { | ||||||
| "id": "pages", | ||||||
| "where": [ | ||||||
| { "ref": ["ID"]}, "=", {"val": "..."} | ||||||
| ] | ||||||
| } | ||||||
| ] | ||||||
| } | ||||||
| ``` | ||||||
|
|
||||||
| Below is an example of how this can be used together to build a CQL statement: | ||||||
|
|
||||||
| ```java | ||||||
| // bookshop.Books[year = 2020].author // [!code focus] | ||||||
| Authors_ authors = CQL.entity(Books_.class).filter(b -> b.year().eq(2020)).author(); // [!code focus] | ||||||
|
|
||||||
|
|
@@ -1325,8 +1380,102 @@ StructuredType<?> authors = | |||||
| Select.from(authors).columns("name"); // [!code focus] | ||||||
| ``` | ||||||
|
|
||||||
| You can also get [entity references](query-execution#entity-refs) from the result of a CDS QL statement to address an entity via its key values in other statements. | ||||||
| An existing reference can be reused as an object or a variable, or a new reference can be built on top of it. | ||||||
|
|
||||||
| Given a simple reference pointing to the book created as follows. | ||||||
|
||||||
| Given a simple reference pointing to the book created as follows. | |
| For the upcoming examples, let's assume a simple reference pointing to the book created as follows: |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use active voice and improve clarity. Change 'With CQL.to(...) the same is produced dynamically' to 'Use CQL.to(...) to produce the same result dynamically.'
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use active voice and improve clarity. Change "This new reference might be used as the root of its own statement" to "You can use this new reference as the root of its own statement" to be more direct and actionable.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use active voice and improve clarity. Change "This new reference might be used" to "You can use this new reference" to be more direct and actionable.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarity improvement: The sentence 'To navigate to the parent, you can strip segment from the end of the ref' is missing an article. It should read: 'To navigate to the parent, you can strip a segment from the end of the ref.'
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use active voice and improve clarity. Change 'To navigate to the parent, you can strip segment from the end of the ref' to 'To navigate to the parent, strip the segment from the end of the reference.' Also, 'segment' should be 'a segment' for proper grammar.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve sentence structure for better readability. Change "To navigate to the parent, you can strip segment from the end of the ref" to "To navigate to the parent, you can strip a segment from the end of the reference." Note the addition of the article "a" and using "reference" instead of "ref" for consistency.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar error: Add an article. Change "strip segment from the end" to "strip a segment from the end" for proper grammar.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarity improvement: The phrase 'Test this code thoroughly and ensure that you do not omit the filters or change the reference so that it becomes inconsistent' is vague and unclear. Consider revising to: 'Ensure thorough testing when modifying references to avoid omitting filters or creating inconsistent reference states.'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Test this code thoroughly and ensure that you do not omit the filters or change the reference so that it becomes inconsistent. | |
| Ensure thorough testing when modifying references to avoid omitting filters or creating inconsistent reference states. |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve clarity and fix grammar. Change 'Test this code thoroughly and ensure that you do not omit the filters or change the reference so that it becomes inconsistent' to 'Test this code thoroughly to ensure you do not omit filters or make the reference inconsistent.'
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve sentence structure and clarity. Consider: "Test this code thoroughly and ensure that you do not omit filters or make the reference inconsistent." This removes redundancy and improves flow.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix grammar and improve clarity. Change 'Such references are usually relative, they do not have the name of the entity in their root' to 'Such references are usually relative; they do not include the entity name in their root.' Use a semicolon to properly connect the related clauses.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use active voice instead of passive voice. Change 'Such references are usually relative, they do not have the name of the entity in their root. They can include filters in their segments except in the last one' to 'Such references are usually relative and do not have the entity name in their root. You can include filters in their segments except in the last one.'
renejeglinsky marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Element references can be extended with the same APIs as the entity references. | |
| Element references can be extended with the same APIs as the [entity references](#entity-refs). |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sentence uses passive voice. Consider revising to:
"You rarely use absolute element references."
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use active voice and improve clarity. Change "Element references share the same features and limitations as entity references and cannot be used with" to "Element references have the same features and limitations as entity references and you cannot use them with" to make it more direct and clear.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use active voice and improve clarity. Change 'Element references share the same features and limitations as entity references and cannot be used with CqnAnalyzer' to 'Element references have the same features and limitations as entity references. You cannot use them with CqnAnalyzer.'
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use active voice instead of passive voice. Change 'Element references share the same features and limitations as entity references and cannot be used with [CqnAnalyzer]' to 'Element references share the same features and limitations as entity references, and you cannot use them with [CqnAnalyzer]'.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve sentence structure and clarity. The sentence "Element references share the same features and limitations as entity references and cannot be used with [CqnAnalyzer]" could be clearer by separating the concepts.
Suggested revision:
Element references share the same features and limitations as entity references. However, you cannot use them with [`CqnAnalyzer`](/java/working-with-cql/query-introspection#cqnanalyzer).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use active voice instead of passive voice. Change "They can be used" to "You can use them" for better clarity and directness.
Suggested revision: