Microservices: shared-db for java #2142
Conversation
guides/deployment/microservices.md
Outdated
| ``` | ||
| ::: | ||
|
|
||
| <div class="impl node"> |
There was a problem hiding this comment.
Is there nothing similar for Java?
| git submodule add https://github.com/capire/common-java | ||
| git submodule add https://github.com/capire/bookshop-java | ||
| git submodule add https://github.com/capire/data-viewer-java | ||
| git submodule update --init |
There was a problem hiding this comment.
When will those be available? Asking to make sure we don't merge this PR before
|
Does this also need to be adapted to bookstore-java and so on? |
No, no changes here up to now |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Here's a supportive code review enhanced by AI assistance. These suggestions offer potential improvements and insights to consider, though they're recommendations rather than requirements. You have full control over which feedback to implement based on your project's needs and goals. The AI analysis is here to complement your expertise and help streamline your development process.
Model: claude-sonnet-4-20250514 | Prompt Tokens: 5859 | Completion Tokens: 574
| ``` | ||
| > The outcome of this looks and behaves exactly as the monorepo layout in *[cap/samples](https://github.com/capire/samples)*, so we can exercise the subsequent steps in there... | ||
|
|
There was a problem hiding this comment.
Remove the extra blank line to maintain consistent spacing throughout the document.
| [@capire/samples](https://github.com/capire/samples#readme) already has an all-in-one deployment implemented. Similar steps are necessary to convert projects with multiple CAP applications into a shared database deployment. | ||
| For Node.js, [@capire/samples](https://github.com/capire/samples#readme) already has an all-in-one deployment implemented. Similar steps are necessary to convert projects with multiple CAP applications into a shared database deployment. | ||
|
|
||
| <font color=red size=+2>TODO</font> For CAP Java, [@capire/samples-java](https://github.com/capire/samples-java#readme) already has an all-in-one deployment implemented. Similar steps are necessary to convert projects with multiple CAP applications into a shared database deployment. |
There was a problem hiding this comment.
The TODO marker should be formatted as a proper note or warning block instead of using HTML font tags. Consider using:
::: warning TODO
For CAP Java, [@capire/samples-java](https://github.com/capire/samples-java#readme) already has an all-in-one deployment implemented. Similar steps are necessary to convert projects with multiple CAP applications into a shared database deployment.
:::| { | ||
| "version": "1.1.0", | ||
| "emname": "samples-emname", // [!code --] | ||
| "version": "1.1.0", | ||
| "namespace": "default/samples/1", // [!code --] |
There was a problem hiding this comment.
There's a duplicate line in the JSON configuration. Remove the duplicate "version": "1.1.0", line:
{
"version": "1.1.0",
"options": {
"management": true,
"messagingrest": true,
"messaging": true
},| ::: | ||
|
|
||
| Add build commands for each module to be deployed: | ||
| In Node.js, add build commands for each module to be prepared for deployment: |
There was a problem hiding this comment.
Change "prepared for deployment" to "deployed" to use active voice and present tense:
In Node.js, add build commands for each module to be deployed:| </dependency> | ||
| ... | ||
| ``` | ||
| ::: |
There was a problem hiding this comment.
Add a missing closing tag for the details section. The section appears to be incomplete without proper closure.
No description provided.