Skip to content

Conversation

@adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Nov 14, 2025

Summary

Add modal for viewing an individual failover event, which is shown when "See more" in the table is clicked

Test plan

Unit tests + ran locally.

With Primary cluster failover

Screenshot 2025-11-14 at 19 12 13

With cluster attributes (more are shown on scroll)

Screenshot 2025-11-14 at 19 12 05

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a failover history modal component to display detailed failover information, including ID, timestamp, and cluster transitions organized by scope and attribute. The modal is integrated into the existing domain page failover active-active view and is triggered by clicking a "See more" button.

  • New DomainPageFailoverModal component with comprehensive styling and test coverage
  • Integration with DomainPageFailoverActiveActive component using React state management
  • Display of failover information in a structured table format with cluster transition visualization

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
domain-page-failover-modal.types.ts Type definitions for the modal component props
domain-page-failover-modal.tsx Modal component implementation with table display and formatted data
domain-page-failover-modal.styles.ts Styled components and BaseUI overrides for modal appearance
domain-page-failover-modal.test.tsx Comprehensive unit tests for modal component behavior
domain-page-failover-active-active.tsx Integration of modal with state management and button click handler
domain-page-failover-active-active.test.tsx Updated tests to verify modal component is rendered

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
@adhityamamallan adhityamamallan marked this pull request as ready for review November 14, 2025 18:14
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
@adhityamamallan adhityamamallan changed the title feat: Add failover history modal feat: Add modal to view full failover event Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant