-
Notifications
You must be signed in to change notification settings - Fork 124
feat: Add modal to view full failover event #1080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Add modal to view full failover event #1080
Conversation
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a failover history modal component to display detailed failover information, including ID, timestamp, and cluster transitions organized by scope and attribute. The modal is integrated into the existing domain page failover active-active view and is triggered by clicking a "See more" button.
- New
DomainPageFailoverModalcomponent with comprehensive styling and test coverage - Integration with
DomainPageFailoverActiveActivecomponent using React state management - Display of failover information in a structured table format with cluster transition visualization
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
domain-page-failover-modal.types.ts |
Type definitions for the modal component props |
domain-page-failover-modal.tsx |
Modal component implementation with table display and formatted data |
domain-page-failover-modal.styles.ts |
Styled components and BaseUI overrides for modal appearance |
domain-page-failover-modal.test.tsx |
Comprehensive unit tests for modal component behavior |
domain-page-failover-active-active.tsx |
Integration of modal with state management and button click handler |
domain-page-failover-active-active.test.tsx |
Updated tests to verify modal component is rendered |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/views/domain-page/domain-page-failover-modal/domain-page-failover-modal.tsx
Outdated
Show resolved
Hide resolved
src/views/domain-page/domain-page-failover-modal/domain-page-failover-modal.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Summary
Add modal for viewing an individual failover event, which is shown when "See more" in the table is clicked
Test plan
Unit tests + ran locally.
With Primary cluster failover
With cluster attributes (more are shown on scroll)