-
Notifications
You must be signed in to change notification settings - Fork 125
feat: Filters for Failover History Table #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Filters for Failover History Table #1079
Conversation
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
b629f46 to
3bec929
Compare
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds filtering capabilities to the Failover History table for active-active domains, allowing users to filter by cluster attribute scope and value. The filters have dependent behavior where the value filter options are determined by the selected scope.
Key changes:
- Introduced a new
DomainPageFailoversFilterscomponent with two dependent combobox filters and a reset button - Integrated filters into the main failovers page, conditionally rendered only for active-active domains
- Removed unused styles file from the failovers component
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/views/domain-page/domain-page-failovers/domain-page-failovers.tsx |
Integrated the new filters component with conditional rendering for active-active domains and updated query params handling |
src/views/domain-page/domain-page-failovers/domain-page-failovers.styles.ts |
Removed unused styles file that contained only padding styles |
src/views/domain-page/domain-page-failovers/__tests__/domain-page-failovers.test.tsx |
Added mock for filters component and test case to verify filters render for active-active domains |
src/views/domain-page/domain-page-failovers-filters/domain-page-failovers-filters.tsx |
Created new filters component with scope and value comboboxes that have dependent behavior |
src/views/domain-page/domain-page-failovers-filters/domain-page-failovers-filters.styles.ts |
Added responsive styling for filter layout with mobile-first approach |
src/views/domain-page/domain-page-failovers-filters/__tests__/domain-page-failovers-filters.test.tsx |
Comprehensive test suite covering all filter interactions and edge cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I'm wondering how to repro the failover data on my local? |
...s/domain-page/domain-page-failovers-filters/__tests__/domain-page-failovers-filters.test.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Summary
Test plan
Unit tests + ran locally.
Unset
Suggestions
City ID
Primary cluster failovers only (cluster attribute value is greyed out)