Skip to content

Conversation

@adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Nov 14, 2025

Summary

  • Add filters for Failover History table, but only for active-active domains
  • Create filter for Cluster Attribute Scope, which depends on domain description to suggest possible scopes
  • Create filter for Cluster Attribute Value, which depends on selected scope to suggest possible values/names
  • Remove (now) unused styles file from DomainPageFailovers

Test plan

Unit tests + ran locally.

Unset

Screenshot 2025-11-14 at 14 42 09

Suggestions

Screenshot 2025-11-14 at 14 46 30 Screenshot 2025-11-14 at 14 46 20

City ID

Screenshot 2025-11-14 at 14 42 03

Primary cluster failovers only (cluster attribute value is greyed out)

Screenshot 2025-11-14 at 14 42 17

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
@adhityamamallan adhityamamallan force-pushed the failover-history-filters branch from b629f46 to 3bec929 Compare November 14, 2025 17:34
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
@adhityamamallan adhityamamallan marked this pull request as ready for review November 14, 2025 17:39
Copilot finished reviewing on behalf of adhityamamallan November 14, 2025 17:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds filtering capabilities to the Failover History table for active-active domains, allowing users to filter by cluster attribute scope and value. The filters have dependent behavior where the value filter options are determined by the selected scope.

Key changes:

  • Introduced a new DomainPageFailoversFilters component with two dependent combobox filters and a reset button
  • Integrated filters into the main failovers page, conditionally rendered only for active-active domains
  • Removed unused styles file from the failovers component

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/views/domain-page/domain-page-failovers/domain-page-failovers.tsx Integrated the new filters component with conditional rendering for active-active domains and updated query params handling
src/views/domain-page/domain-page-failovers/domain-page-failovers.styles.ts Removed unused styles file that contained only padding styles
src/views/domain-page/domain-page-failovers/__tests__/domain-page-failovers.test.tsx Added mock for filters component and test case to verify filters render for active-active domains
src/views/domain-page/domain-page-failovers-filters/domain-page-failovers-filters.tsx Created new filters component with scope and value comboboxes that have dependent behavior
src/views/domain-page/domain-page-failovers-filters/domain-page-failovers-filters.styles.ts Added responsive styling for filter layout with mobile-first approach
src/views/domain-page/domain-page-failovers-filters/__tests__/domain-page-failovers-filters.test.tsx Comprehensive test suite covering all filter interactions and edge cases

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@macrotim
Copy link
Member

I'm wondering how to repro the failover data on my local?

@adhityamamallan adhityamamallan merged commit 1054087 into cadence-workflow:master Nov 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants