-
Notifications
You must be signed in to change notification settings - Fork 2
[Docs] Update faq.md #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2,4 +2,19 @@ | |||||||||||||||||||||
|
|
||||||||||||||||||||||
| 1. How to resolve when pip install fails? | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| See [installation](https://cachemon.github.io/libCacheSim-python/getting_started/installation/). | ||||||||||||||||||||||
| See [installation](https://cachemon.github.io/libCacheSim-python/getting_started/installation/). | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| 2. Get an error message like "cannot find Python package" when building. | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| The reason is that when building a Python binding package, we need the header and other necessary modules. | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| If you can install software directly, | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ```shell | ||||||||||||||||||||||
| [sudo] apt install python3-dev | ||||||||||||||||||||||
| ``` | ||||||||||||||||||||||
|
Comment on lines
+11
to
+15
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The instruction to install software directly is vague and only provides a Debian/Ubuntu example. Consider expanding this to include instructions for other common operating systems like RHEL/CentOS/Fedora and macOS.
Suggested change
|
||||||||||||||||||||||
| If not, please install Python somewhere and set environment variables to help the building system find them. | ||||||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The phrase 'If not, please install Python somewhere and set environment variables to help the building system find them.' is ambiguous. Clarify that this applies when Python is installed in a custom location and remind users to replace placeholders in the subsequent command.
Suggested change
|
||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ```shell | ||||||||||||||||||||||
| export CMAKE_ARGS="-DPython3_ROOT_DIR=${Python3_ROOT_DIR} -DPython3_INCLUDE_DIR=${Python3_INCLUDE_DIR} -DPython3_EXECUTABLE=${Python3_EXECUTABLE}" | ||||||||||||||||||||||
| ``` | ||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sentence 'The reason is that when building a Python binding package, we need the header and other necessary modules.' could be more precise. Consider rephrasing to clearly state the requirement for Python development headers and libraries.