Add runtime API for shared heap destroy and related test cases #4730
+396
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TianlongLiang
force-pushed
the
dev/shared_heap_destroy
branch
from
9f1bf2d to
6c7ba78
Compare
TianlongLiang
requested review from
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
lum1n0us
reviewed
Dec 1, 2025
| } | ||
| prev = prev->next; | ||
| cur = cur->next; | ||
| } |
Collaborator
There was a problem hiding this comment.
It seems that the process of looking for prev can be integrated into the above loop to ensure head_found.
But the current implementation is definitely functional. It is acceptable to keep it as is.
| return false; | ||
| } | ||
| if (!is_chain_head) { | ||
| LOG_WARNING("Shared heap %p isn't the head of a shared heap chain.", |
Collaborator
There was a problem hiding this comment.
Suppose there are two chains, A-B-C and B-C, and both need to be wasm_runtime_destroy_shared_heap() entire_chain.
First, destroy the first chain, which is A-B-C. When deleting up to C, it is discovered that C is not the head, and then the condition if (!is_chain_head) will fail and return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And for existing test cases, fix some compile warnings