Skip to content

Fix bug in tag overflow checks #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcoferrer wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix bug in tag overflow checks #19

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e8542b5
bug fix tag overflow checks
marcoferrer Aug 11, 2025
3acabfc
bug fix tag overflow checks
marcoferrer Aug 12, 2025
f3d4cdb
Update tag_test.go
marcoferrer Aug 14, 2025
157d28b
address PR feedback
marcoferrer Oct 10, 2025
650371d
Merge branch 'bufbuild:main' into bug-fix-tag-overflow
marcoferrer Oct 10, 2025
3928e27
add testdata for extension overflow
marcoferrer Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/tdp/tag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,5 +79,5 @@ func (t Tag) Format(s fmt.State, verb rune) {
// Returns whether this tag is "too large", i.e., if it has more than 32 bits
// when decoded.
func (t Tag) Overflows() bool {
return bits.LeadingZeros64(uint64(t)) < (64 - 32 + 4)
return bits.LeadingZeros64(uint64(t)) < (64 - 32 - 4)
}
13 changes: 13 additions & 0 deletions internal/tdp/tag_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package tdp

import (
"google.golang.org/protobuf/encoding/protowire"
"testing"
)

func TestTagOverflows(t *testing.T) {
tag := EncodeTag(protowire.MaxValidNumber, protowire.BytesType)
if tag.Overflows() {
t.Error("protowire.MaxValidNumber should not overflow")
}
}