Skip to content

Conversation

@sirdeggen
Copy link
Collaborator

@sirdeggen sirdeggen commented Nov 19, 2025

Description of Changes

Added Certificate.fromObject method for creating Certificate instances from plain objects.

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes
  • I have run npm run doc and npm run lint one final time before requesting a review
  • I have fixed all linter errors to ensure these changes are compliant with ts-standard
  • I have run npm version patch so that my changes will trigger a new version to be released when they are merged

add convenience function to create Certificate from the json you’d receive from a signing server
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link

🏁 Benchmark Comparison (Node 22)

Comparing this PR (781e7f1) against master (726e75d).

⚠️ 1 regression detected (>5% slower).

Regressions

  • ⚠️ Reader & Writer – mixed ops is 9.09% slower (0.24 ms vs 0.22 ms).
Benchmark Metric PR Branch Master Δ Change
BigNumber Arithmetic mul large numbers 8.92 ms 8.96 ms -0.04 ms -0.45%
BigNumber Arithmetic add large numbers 1.47 ms 1.50 ms -0.03 ms -2.00%
BigNumber Serialization toSm big 2.93 ms 2.99 ms -0.06 ms -2.01%
BigNumber Serialization toSm little 3.04 ms 3.09 ms -0.05 ms -1.62%
BigNumber Serialization fromSm big 3.05 ms 3.04 ms +0.01 ms +0.33%
BigNumber Serialization fromSm little 3.09 ms 3.21 ms -0.12 ms -3.74%
BigNumber Serialization fromScriptNum 3.11 ms 3.15 ms -0.04 ms -1.27%
Script Serialization Big script round trip 3.88 ms 3.85 ms +0.03 ms +0.78%
Transaction Verification deep chain verify 442.68 ms 439.60 ms +3.08 ms +0.70%
Transaction Verification wide transaction verify 453.15 ms 455.20 ms -2.05 ms -0.45%
Transaction Verification large tx verify 224.73 ms 226.60 ms -1.87 ms -0.83%
Transaction Verification nested inputs verify 103.67 ms 103.96 ms -0.29 ms -0.28%
Symmetric Key encrypt large 2MB 1537.46 ms 1504.28 ms +33.18 ms +2.21%
Symmetric Key decrypt large 2MB 1532.73 ms 1513.96 ms +18.77 ms +1.24%
Symmetric Key encrypt 50 small 6.69 ms 6.51 ms +0.18 ms +2.76%
Symmetric Key decrypt 50 small 6.47 ms 6.32 ms +0.15 ms +2.37%
Symmetric Key encrypt 200 medium 162.45 ms 155.83 ms +6.62 ms +4.25%
Symmetric Key decrypt 200 medium 157.40 ms 155.30 ms +2.10 ms +1.35%
Reader & Writer mixed ops 0.24 ms 0.22 ms +0.02 ms +9.09%
Reader & Writer large payloads 28.94 ms 28.93 ms +0.01 ms +0.03%
Reader & Writer 3000 small payloads 1.83 ms 1.75 ms +0.08 ms +4.57%
Reader & Writer 400 medium payloads 16.01 ms 15.45 ms +0.56 ms +3.62%
Atomic BEEF Transaction.toAtomicBEEF 1.54 ms 1.51 ms +0.03 ms +1.99%
Atomic BEEF Transaction.fromAtomicBEEF 3.72 ms 3.61 ms +0.11 ms +3.05%

@sonarqubecloud
Copy link

@github-actions
Copy link

🏁 Benchmark Comparison (Node 22)

Comparing this PR (d9624f6) against master (726e75d).

✅ No regressions over the 5% threshold detected.

Benchmark Metric PR Branch Master Δ Change
BigNumber Arithmetic mul large numbers 9.22 ms 9.07 ms +0.15 ms +1.65%
BigNumber Arithmetic add large numbers 1.50 ms 1.51 ms -0.01 ms -0.66%
BigNumber Serialization toSm big 3.04 ms 3.01 ms +0.03 ms +1.00%
BigNumber Serialization toSm little 3.15 ms 3.12 ms +0.03 ms +0.96%
BigNumber Serialization fromSm big 3.16 ms 3.14 ms +0.02 ms +0.64%
BigNumber Serialization fromSm little 3.28 ms 3.27 ms +0.01 ms +0.31%
BigNumber Serialization fromScriptNum 3.33 ms 3.24 ms +0.09 ms +2.78%
Script Serialization Big script round trip 4.06 ms 3.95 ms +0.11 ms +2.78%
Transaction Verification deep chain verify 458.65 ms 457.07 ms +1.58 ms +0.35%
Transaction Verification wide transaction verify 467.05 ms 467.39 ms -0.34 ms -0.07%
Transaction Verification large tx verify 233.35 ms 232.33 ms +1.02 ms +0.44%
Transaction Verification nested inputs verify 111.05 ms 107.95 ms +3.10 ms +2.87%
Symmetric Key encrypt large 2MB 1510.60 ms 1549.92 ms -39.32 ms -2.54%
Symmetric Key decrypt large 2MB 1509.11 ms 1545.88 ms -36.77 ms -2.38%
Symmetric Key encrypt 50 small 6.53 ms 6.74 ms -0.21 ms -3.12%
Symmetric Key decrypt 50 small 6.33 ms 6.56 ms -0.23 ms -3.51%
Symmetric Key encrypt 200 medium 157.30 ms 161.96 ms -4.66 ms -2.88%
Symmetric Key decrypt 200 medium 157.27 ms 160.85 ms -3.58 ms -2.23%
Reader & Writer mixed ops 0.23 ms 0.23 ms +0.00 ms 0.00%
Reader & Writer large payloads 30.10 ms 30.83 ms -0.73 ms -2.37%
Reader & Writer 3000 small payloads 1.95 ms 1.88 ms +0.07 ms +3.72%
Reader & Writer 400 medium payloads 16.90 ms 17.01 ms -0.11 ms -0.65%
Atomic BEEF Transaction.toAtomicBEEF 1.59 ms 1.56 ms +0.03 ms +1.92%
Atomic BEEF Transaction.fromAtomicBEEF 3.76 ms 3.83 ms -0.07 ms -1.83%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants