Skip to content

fix(websocket): improve error and close handling #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(websocket): improve error and close handling #66

wants to merge 1 commit into from

Conversation

@HansSchouten
Copy link

@HansSchouten HansSchouten commented Sep 24, 2025

  • Use repr() when logging errors to ensure useful output even for non-string errors
  • Update on_close signature to accept (code, reason) for compatibility with newer websocket-client
  • Remove self.receiveThread.exit() since the exit method does not exist in receiveThread
  • Log close code and reason for easier debugging

@HansSchouten
fix(websocket): improve error and close handling
56eb419 
- Use repr() when logging errors to ensure useful output even for non-string errors
- Update on_close signature to accept (code, reason) for compatibility with newer websocket-client
- Remove self.receiveThread.exit() since the exit method does not exist in receiveThread
- Log close code and reason for easier debugging
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@HansSchouten