Skip to content

Use Timeout.InfiniteTimeSpan #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

Use Timeout.InfiniteTimeSpan #668

merged 1 commit into from
Feb 13, 2025

Conversation

@Joy-less
Copy link
Contributor

@Joy-less Joy-less commented Feb 5, 2025

This is just a readability thing. Use Timeout.InfiniteTimeSpan not new TimeSpan(0, 0, 0, 0, -1).

@coveralls
Copy link

coveralls commented Feb 6, 2025

Coverage Status

coverage: 99.169% (+0.02%) from 99.152%
when pulling 3c25cfc on Joy-less:use-timeout.infinitetimespan
into da00197 on bitfaster:main.

bitfaster
bitfaster approved these changes Feb 6, 2025
View reviewed changes
Copy link
Owner

@bitfaster bitfaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Joy-less Joy-less mentioned this pull request Feb 6, 2025
Open
@bitfaster bitfaster merged commit 0c6dd7f into bitfaster:main Feb 13, 2025
13 checks passed
@Joy-less Joy-less deleted the use-timeout.infinitetimespan branch February 13, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitfaster bitfaster bitfaster approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Joy-less @coveralls @bitfaster