Eagerly purge deleted items from internal LRU queues #664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When items are deleted, they remain in the internal queues until fully cycled out of cold. This is because the cycle/route methods do not inspect
WasDeleted. Instead, purge them as items transition from queue to queue as part of cycle.This change doesn't trigger double dispose/event due to the implementation of the
Movemethod first attempting to remove the item from the dictionary:Scenarios covered:
Found two other bugs in Trim logic: