Skip to content

Conversation

@reez
Copy link
Collaborator

@reez reez commented Nov 19, 2025

Description

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • UI changes tested on small, medium, and large devices to ensure layout consistency

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

Copy link
Collaborator

@r1b2ns r1b2ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esplora and Kyoto

✅ Create new wallet with Bip84 and bip86
✅ Delete wallets
✅ Show wallet backup and descriptors
✅ send and receive sats
✅ Full and progressive scan

In this version I noticed some issues with Kyoto’s synchronization speed, but I think we can improve that after the 2.2.1 update.

Another issue is the AppIcon. I’m not sure why, but the icon doesn’t appear in the project file on my side, maybe it’s just a misunderstanding with the .xcproject. I noticed in commit 809f542 a new icon called box-roted.png. Is this the new app icon?

ACK 16fd1ce

@reez
Copy link
Collaborator Author

reez commented Nov 24, 2025

Esplora and Kyoto

✅ Create new wallet with Bip84 and bip86 ✅ Delete wallets ✅ Show wallet backup and descriptors ✅ send and receive sats ✅ Full and progressive scan

In this version I noticed some issues with Kyoto’s synchronization speed, but I think we can improve that after the 2.2.1 update.

Another issue is the AppIcon. I’m not sure why, but the icon doesn’t appear in the project file on my side, maybe it’s just a misunderstanding with the .xcproject. I noticed in commit 809f542 a new icon called box-roted.png. Is this the new app icon?

ACK 16fd1ce

YOU ARE THE BEST!

Using the new AppIcon generated with Icon Composer, weird apple doesnt do backward support well for non Xcode26, but this is good to know so I will add a note in the readme about it.

@reez reez merged commit fa90bbc into bitcoindevkit:main Nov 24, 2025
1 check passed
@reez reez deleted the v2.2.1 branch November 24, 2025 14:32
@reez reez mentioned this pull request Nov 24, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants