Skip to content

Conversation

@andriyDev
Copy link
Contributor

Objective

  • Fix cargo t -p bevy_asset --all-features.
    • Note: all-features do not run on CI!
  • The doc tests for the WebAssetPlugin don't compile at all. There are bad imports and we don't even add the AssetPlugin.

Solution

  • Add missing imports, and add missing plugins to the App.

Testing

  • Ran cargo t -p bevy_asset --all-features and it passes now!

@andriyDev andriyDev added D-Trivial Nice and easy! A great choice to get started with Bevy A-Assets Load files from disk to use for things like images, models, and sounds C-Testing A change that impacts how we test Bevy or how users test their apps S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 28, 2025
@james7132 james7132 changed the title Remove all the unused doc test stuff for the WebAssetPlugin. Fix the doc test for WebAssetPlugin Nov 28, 2025
@andriyDev andriyDev requested a review from kfc35 December 1, 2025 00:21
Copy link
Contributor

@kfc35 kfc35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I also ran cargo t -p bevy_asset --all-features locally with these changes and it works for me as well.

@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Assets Load files from disk to use for things like images, models, and sounds C-Testing A change that impacts how we test Bevy or how users test their apps D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants