Skip to content

scrollbar helper functions #21937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

scrollbar helper functions #21937

wants to merge 9 commits into from
+170 −0

Conversation

@ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Nov 25, 2025 •
edited
Loading

Objective

Add helper functions to ComputedNode to compute the scrollbar areas of a UI node.

Solution

Add horizontal_scrollbar and vertical_scrollbar functions to ComputedNode. If a scrollbar is present, these return an option wrapping a tuple of the node-centered bounding Rect for the scrollbar, and the start and end points of the thumb.

Testing

Includes a couple of tests in the uinode module.

@ickshonpe ickshonpe added A-UI Graphical user interfaces, styles, layouts, and widgets D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 26, 2025
kfc35
kfc35 approved these changes Nov 29, 2025
View reviewed changes
Copy link
Contributor

@kfc35 kfc35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor, non blocking comments, LGTM

ickshonpe and others added 4 commits December 2, 2025 10:23
@ickshonpe @kfc35
Update crates/bevy_ui/src/ui_node.rs
b14ce56 
Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com>
@ickshonpe @kfc35
Update crates/bevy_ui/src/ui_node.rs
7872b64 
Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com>
@ickshonpe
cargo fmt --all
a302192
@ickshonpe
Merge branch 'main' into computed-scrollbar
a3e523b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kfc35 kfc35 kfc35 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-UI Graphical user interfaces, styles, layouts, and widgets D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ickshonpe @kfc35