-
Notifications
You must be signed in to change notification settings - Fork 12
Merge Master to Main #2934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Merge Master to Main #2934
Changes from all commits
08654ca
2f947f2
8cac89e
a1143ff
15f9fdd
bd789b8
3491012
175371f
c22ad7d
a71799d
d06a721
4cebb7e
5481767
d043cad
a62ea9d
fb88582
9cfc48d
adbbdb9
d03df1f
bde38f9
732b40a
e0d4182
27915b6
55febdf
652bd5d
17a9d19
7383d2c
2033cb8
0031265
48f021e
36926ec
1f82c12
64d5b9d
549b6d9
63386f0
52aa54a
34eba72
fe767bf
d8cf063
a43f374
fdb5bb5
ded077c
20546cd
0579aa5
4bf85c3
b74d724
b6075e2
38c3ac0
88a15d5
f182400
ea0091c
2fe3a52
b78ecee
cc48485
348ff3d
7a87c17
a647b05
02c26a3
dd3e4a7
4646cb7
46920be
399cb4f
ebd6d8f
73ef70e
6f14317
27be17e
51d52f3
f0050e7
870fa6d
ca1144e
1d5f58d
f811cc2
06e4e23
711a468
b760903
b673d83
498784e
2dc7de7
74ae98a
2a53cf9
4103d18
539fb9b
9222fce
362644b
255a4ad
d2b4c2c
ae17ccd
2bd0123
38e8389
d328f26
1366ac1
805babf
80742b1
052fb32
4a0ae8f
539d3ab
315ca08
43334e4
2529237
deb3e64
4c9245e
954c7b0
58e9a82
2986d34
320d7e7
4f7329f
6a5463e
19c8e7c
bee899d
5a26a2f
d0a2c82
32f347d
d7f1466
641276a
7d294ae
befa03b
eb06bcf
030ae73
9be5dca
6d67e59
16d5168
b8aae10
bf5a3af
edc1391
40bc6ca
6f6c084
8cd9d21
6b05d73
208e043
8b36d90
047f6b2
c0f814f
50a87fa
cce5ce7
d56e1c3
6c776af
f5d6fe9
05cbcd9
ee856e8
6a670e5
01a1711
61fd870
ea0675a
a160d9d
5b6477b
796171c
33e5348
9d893aa
221990d
8904554
f0a6d8e
6bb19ac
e1c4076
277328f
0fcc1b2
25b3275
f2f1e54
cd26985
fba3d67
af66604
ec73d37
d54f2c6
0daa20c
89b82e4
3e9a407
a2a425a
abb9ab3
5a7ae7a
8dde061
1a8d79f
1a908ed
a872a1a
926ff69
5345788
949fccf
2ac7595
92c9b36
91bd757
c06b6ea
e975353
bc96c10
292fcd9
18a63e2
2ab757b
d81b8e7
c5154d5
abe5d08
dc86ede
4d143e2
0b0cd5c
044202a
71e0bbe
fe5463f
14a2820
8b6c3aa
c098014
b777b57
51da609
9d6baf6
ee78b4f
7ff94b9
1c5320e
66e0d3c
edc37d3
2886bf8
6ba86c2
17c40a8
d7b7696
385adea
382401f
db68b4d
ab55b81
a95ee2c
2132e67
22be376
282a8ad
936fd88
8827eb6
c0b393b
2fbb5e4
ac6001a
db326e6
720997d
31be796
8fbfc17
d0c0812
5b31d5e
e949598
f852f83
18f1593
ba11ace
bd56295
23a12da
393c432
6438088
7fb673c
957b101
fad76ad
6a48384
50d8e3f
4e98277
1d29a02
e70893c
e60b2cd
3ae166c
d325095
d3a23f4
e137636
649918d
e9f26af
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| *.sh text eol=lf |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| --- | ||
| name: Bug report | ||
| about: Create a report to help us improve | ||
| title: '' | ||
| labels: '' | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| **Describe the bug** | ||
| A clear and concise description of what the bug is. | ||
|
|
||
| **To Reproduce** | ||
| Steps to reproduce the behavior: | ||
| 1. Go to '...' | ||
| 2. Click on '....' | ||
| 3. Scroll down to '....' | ||
| 4. See error | ||
|
|
||
| **Expected behavior** | ||
| A clear and concise description of what you expected to happen. | ||
|
|
||
| **Screenshots** | ||
| If applicable, add screenshots to help explain your problem. | ||
|
|
||
| **Desktop (please complete the following information):** | ||
| - OS: [e.g. iOS] | ||
| - Browser [e.g. chrome, safari] | ||
| - Version [e.g. 22] | ||
|
|
||
| **Smartphone (please complete the following information):** | ||
| - Device: [e.g. iPhone6] | ||
| - OS: [e.g. iOS8.1] | ||
| - Browser [e.g. stock browser, safari] | ||
| - Version [e.g. 22] | ||
|
|
||
| **Additional context** | ||
| Add any other context about the problem here. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --- | ||
| name: Feature request | ||
| about: Suggest an idea for this project | ||
| title: '' | ||
| labels: '' | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| **Is your feature request related to a problem? Please describe.** | ||
| A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] | ||
|
|
||
| **Describe the solution you'd like** | ||
| A clear and concise description of what you want to happen. | ||
|
|
||
| **Describe alternatives you've considered** | ||
| A clear and concise description of any alternative solutions or features you've considered. | ||
|
|
||
| **Additional context** | ||
| Add any other context or screenshots about the feature request here. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| name: Onboarding Request | ||
| about: Request for access to Efiling Hub API and Frontend | ||
| title: "[ONBOARDING]" | ||
| labels: Onboarding | ||
| assignees: akroon3r, alexjoybc | ||
|
|
||
| --- | ||
|
|
||
| After this issue has been opened, please provide the following information: | ||
|
|
||
| - contact email that admins can reach you at | ||
| - a brief description of what you're looking to accomplish by integrating with the efiling-hub | ||
| - a link to github repository of the application that is requesting access to the efiling-hub | ||
| - a list of the types of documents you're looking to upload to the efiling-hub |
| Original file line number | Diff line number | Diff line change | |||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,129 @@ | |||||||||||||||||||||||
| name: Build and Test Apps | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| on: | |||||||||||||||||||||||
| push: | |||||||||||||||||||||||
| branches: [master] | |||||||||||||||||||||||
| pull_request: | |||||||||||||||||||||||
| branches: [master] | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| jobs: | |||||||||||||||||||||||
| yarn: | |||||||||||||||||||||||
| env: | |||||||||||||||||||||||
| FILE_COUNTER: 0 | |||||||||||||||||||||||
| ACTION_DEBUG: true | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| name: Build and Test React Apps | |||||||||||||||||||||||
| runs-on: ubuntu-latest | |||||||||||||||||||||||
| steps: | |||||||||||||||||||||||
| - uses: actions/checkout@v4 | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| - name: Printing node and yarn versions | |||||||||||||||||||||||
| run: node --version && yarn --version | |||||||||||||||||||||||
| # Figure out where yarn is caching things | |||||||||||||||||||||||
| - name: Yarn Cache | |||||||||||||||||||||||
| run: yarn cache dir | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| # Run Yarn Install - eFiling Frontend | |||||||||||||||||||||||
| - name: Run Yarn Install - eFiling Frontend | |||||||||||||||||||||||
| run: yarn --cwd src/frontend/efiling-frontend install | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| # Check lint version | |||||||||||||||||||||||
| - name: Check lint - eFiling Frontend | |||||||||||||||||||||||
| run: yarn --cwd src/frontend/efiling-frontend run lint -v | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| # Run lint - eFiling Frontend | |||||||||||||||||||||||
| - name: Run lint - eFiling Frontend | |||||||||||||||||||||||
| run: yarn --cwd src/frontend/efiling-frontend run lint | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| # Yarn Coverage - eFiling Frontend | |||||||||||||||||||||||
| - name: Run Yarn Coverage - eFiling Frontend | |||||||||||||||||||||||
| run: yarn --cwd /home/runner/work/jag-file-submission/jag-file-submission/src/frontend/efiling-frontend coverage | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| # Run Yarn Install - eFiling Demo | |||||||||||||||||||||||
| - name: Run Yarn Install - eFiling Demo | |||||||||||||||||||||||
| run: yarn --cwd src/frontend/efiling-demo install | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| # Run lint - eFiling Demo | |||||||||||||||||||||||
| - name: Run lint - eFiling Demo | |||||||||||||||||||||||
| run: yarn --cwd src/frontend/efiling-demo run lint | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| # Yarn Coverage - eFiling Demo | |||||||||||||||||||||||
| - name: Run Yarn Coverage - eFiling Demo | |||||||||||||||||||||||
| run: yarn --cwd /home/runner/work/jag-file-submission/jag-file-submission/src/frontend/efiling-demo coverage | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| # Formatting the FRONTEND DEMO coverage report | |||||||||||||||||||||||
| #- name: Format the FRONTEND DEMO coverage report | |||||||||||||||||||||||
| # run: | | |||||||||||||||||||||||
| # pushd . | |||||||||||||||||||||||
| # cd ${{github.workspace}}/src/frontend/efiling-demo/ | |||||||||||||||||||||||
| # ${{github.workspace}}/cc-test-reporter format-coverage -t lcov -o ${{github.workspace}}/coverage/frontend-demo-codeclimate.json coverage/lcov.info | |||||||||||||||||||||||
| # popd | |||||||||||||||||||||||
| # Implement Caching Action for Yarn Project | |||||||||||||||||||||||
| - name: Cache node modules | |||||||||||||||||||||||
| uses: actions/cache@v4 | |||||||||||||||||||||||
| env: | |||||||||||||||||||||||
| cache-name: cache-node-modules | |||||||||||||||||||||||
| with: | |||||||||||||||||||||||
| # YARN cache files are stored in `/home/runner/.cache/yarn/v6` on git actions | |||||||||||||||||||||||
| path: /home/runner/.cache/yarn/v6 | |||||||||||||||||||||||
| key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }} | |||||||||||||||||||||||
| restore-keys: | | |||||||||||||||||||||||
| ${{ runner.os }}-build-${{ env.cache-name }}- | |||||||||||||||||||||||
| ${{ runner.os }}-build- | |||||||||||||||||||||||
| ${{ runner.os }}- | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
|
|
|||||||||||||||||||||||
|
|
|||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| spring-boot: | |||||||||||||||||||||||
| name: Build and Test Java | |||||||||||||||||||||||
| runs-on: ubuntu-latest | |||||||||||||||||||||||
| env: | |||||||||||||||||||||||
| FILE_COUNTER: 0 | |||||||||||||||||||||||
| ACTION_DEBUG: true | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| steps: | |||||||||||||||||||||||
| - name: Checkout Spring Starters Repository | |||||||||||||||||||||||
| uses: actions/checkout@v4 | |||||||||||||||||||||||
| with: | |||||||||||||||||||||||
| repository: bcgov/spring-boot-starters | |||||||||||||||||||||||
| path: spring-boot-starters | |||||||||||||||||||||||
| ref: v1.0.5 | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| # Setup Java Environment | |||||||||||||||||||||||
| - name: Set up JDK 17 | |||||||||||||||||||||||
| uses: actions/setup-java@v1 | |||||||||||||||||||||||
| with: | |||||||||||||||||||||||
| java-version: 17 | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| # TODO REMOVE AFTER SFTP IS IN MAVEN CENTRAL | |||||||||||||||||||||||
| - name: Build Spring Starters | |||||||||||||||||||||||
| run: mvn install -P all --file ./spring-boot-starters/src/pom.xml | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| - name: Checkout File Submission Repository | |||||||||||||||||||||||
| uses: actions/checkout@v2 | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| # Trimming the ref to master in order to publish correct report (paambaati) | |||||||||||||||||||||||
| - name: Set ref/head/master to master | |||||||||||||||||||||||
| run: | | |||||||||||||||||||||||
| echo "GIT_BRANCH=master" >> $GITHUB_ENV | |||||||||||||||||||||||
| #echo "::set-env name=GIT_BRANCH::master" | |||||||||||||||||||||||
| if: env.GIT_BRANCH == 'refs/heads/master' | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| #- uses: actions/cache@v1 | |||||||||||||||||||||||
| # with: | |||||||||||||||||||||||
| # path: ~/.m2/repository | |||||||||||||||||||||||
| # key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }} | |||||||||||||||||||||||
| # restore-keys: | | |||||||||||||||||||||||
| # ${{ runner.os }}-maven- | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| #Set env again?? | |||||||||||||||||||||||
| - name: Set up JDK 17 | |||||||||||||||||||||||
| uses: actions/setup-java@v1 | |||||||||||||||||||||||
| with: | |||||||||||||||||||||||
| java-version: 17 | |||||||||||||||||||||||
|
|
|||||||||||||||||||||||
| # Run Maven Verify to generate all jacoco reports | |||||||||||||||||||||||
| - name: Build with Maven | |||||||||||||||||||||||
| run: mvn -B verify -P all --file src/backend/pom.xml | |||||||||||||||||||||||
|
Comment on lines
+79
to
+129
Check warningCode scanning / CodeQL Workflow does not contain permissions Medium
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
Copilot AutofixAI 7 days ago To address the issue, add a permissions:
contents: readThis ensures the workflow token only has read access to repository contents. No actions in the current jobs require additional write access. Edit
Suggested changeset
1
.github/workflows/build-and-test-apps.yml
Copilot is powered by AI and may make mistakes. Always verify output.
Positive FeedbackNegative Feedback
Refresh and try again.
|
|||||||||||||||||||||||
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Copilot Autofix
AI 7 days ago
To address this issue, we need to explicitly set a
permissionskey at the top level of the workflow file.github/workflows/build-and-test-apps.yml. This key should grant only the minimum necessary access for the jobs in the workflow. Since all current jobs merely build, test, and cache artifacts but do not perform any write operations (e.g., creating releases, commenting, or pushing code), we can safely setcontents: readglobally. This should be inserted before thejobs:section, right after thename:andon:keys (typically after line 7 or 8 in the current file). No additional methods, imports, or definitions are required.