Extend QNX support by adding all currently supported variants #3723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the various (apparently ABI incompatible) versions of QNX that are supported by Rust 1.91+ (QNX 7, QNX 7 with iopkt, QNX8).
Since dylibs are supported by QNX, let's not refuse them in case they were added to the rustc command line.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This is required for backwards compatibility, so that builds that relied on this being the default before version introduction will still work.
With the advent of QNX7 support with iosock, we need at least Rust 1.86.0 so that the new target is understood. Bump the version accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for QNX8 by introducing a version constraint that allows for the selection of the respective ABI target of the Rust compiler. Since QNX also supports dylibs, also include the nto system as dylib supporting platform.
In addition, also add all supported targets to the list of Tier 3 architectures. Since cargo-bazel also needs to know the additional triples, it's version of cfg-expr needs to be bumped.