Skip to content

Use rules_jvm_external for internal dependencies #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use rules_jvm_external for internal dependencies #1786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
350db17
Use buildifier-prebuilt instead of building buildifier
Sep 24, 2025
f42192c
Added rules_jvm_external
Sep 23, 2025
917d5f1
Deleted scala/private/extensions/dev_deps.bzl
Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 23 additions & 69 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ single_version_override(
version = "8.16.1",
)

bazel_dep(name = "rules_jvm_external", version = "6.8")
bazel_dep(name = "rules_proto", version = "6.0.0")
single_version_override(
module_name = "rules_proto",
Expand Down Expand Up @@ -186,27 +187,28 @@ use_repo(
for scala_version in SCALA_3_VERSIONS
]

internal_dev_deps = use_extension(
"//scala/private/extensions:dev_deps.bzl",
"dev_deps",
dev_dependency = True,
)

# See //scala/private:extensions/dev_deps.bzl for notes on some of these repos.
use_repo(
internal_dev_deps,
"com_github_bazelbuild_buildtools",
"com_github_jnr_jffi_native",
"com_google_guava_guava_21_0",
"com_google_guava_guava_21_0_with_file",
"com_twitter__scalding_date",
"org_apache_commons_commons_lang_3_5",
"org_apache_commons_commons_lang_3_5_without_file",
"org_springframework_spring_core",
"org_springframework_spring_tx",
"org_typelevel__cats_core",
"org_typelevel_kind_projector",
rules_scala_test_maven = use_extension("@rules_jvm_external//:extensions.bzl", "maven")
rules_scala_test_maven.install(
name = "rules_scala_test_maven",
artifacts = [
"com.github.jnr:jffi:1.3.13",
"com.google.guava:guava:21.0",
"org.apache.commons:commons-lang3:3.18.0",
"org.springframework:spring-core:6.2.11",
"org.springframework:spring-tx:6.2.11",
"org.typelevel:cats-core_2.12:2.13.0",
"org.typelevel:kind-projector_2.12.20:0.13.4",
],
fetch_sources = True,
lock_file = "//:rules_scala_test_maven.json",
repositories = [
"https://repo.maven.apache.org/maven2",
"https://maven-central.storage-download.googleapis.com/maven2",
"https://mirror.bazel.build/repo1.maven.org/maven2",
"https://jcenter.bintray.com",
],
)
use_repo(rules_scala_test_maven, "rules_scala_test_maven")

java_toolchains = use_extension(
"@rules_java//java:extensions.bzl",
Expand Down Expand Up @@ -255,54 +257,6 @@ bazel_dep(
dev_dependency = True,
repo_name = "bazelci_rules",
)
bazel_dep(
name = "rules_go",
version = "0.58.2",
dev_dependency = True,
repo_name = "io_bazel_rules_go", # for com_github_bazelbuild_buildtools
)
bazel_dep(name = "gazelle", version = "0.45.0", dev_dependency = True)

go_sdk = use_extension(
"@io_bazel_rules_go//go:extensions.bzl",
"go_sdk",
dev_dependency = True,
)
go_sdk.download(version = "1.25.3")

go_deps = use_extension(
"@gazelle//:extensions.bzl",
"go_deps",
dev_dependency = True,
)

# The go_deps.module calls are inspired by the following to get the
# com_github_bazelbuild_buildtools repo to work:
#
# - https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/gazelle/0.39.1/MODULE.bazel#L31-L57
#
# To get the latest version and hashes for each per:
#
# - https://go.dev/ref/mod#go-list-m
# - https://go.dev/ref/mod#checksum-database
#
# go list -m golang.org/x/tools@latest
# curl https://sum.golang.org/lookup/golang.org/x/tools@v0.38.0
go_deps.module(
path = "golang.org/x/tools",
sum = "h1:Hx2Xv8hISq8Lm16jvBZ2VQf+RLmbd7wVUsALibYI/IQ=",
version = "v0.38.0",
)
go_deps.module(
path = "github.com/golang/protobuf",
sum = "h1:i7eJL8qZTpSEXOPTxNKhASYpMn+8e5Q6AdndVa1dWek=",
version = "v1.5.4",
)
use_repo(
go_deps,
"com_github_golang_protobuf",
"org_golang_x_tools",
)

bazel_dep(name = "buildifier_prebuilt", version = "8.2.0.2", dev_dependency = True)
bazel_dep(name = "rules_python", version = "1.6.3", dev_dependency = True)
bazel_dep(name = "rules_shell", version = "0.6.1", dev_dependency = True)
21 changes: 4 additions & 17 deletions MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

84 changes: 61 additions & 23 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,25 +104,6 @@ local_repository(
path = "third_party/test/example_external_workspace",
)

http_archive(
name = "io_bazel_rules_go",
sha256 = "54bbb67a4196170cc60ef3b52a2747ad1759cba4764b4c4752b744080ad99947",
urls = [
"https://mirror.bazel.build/github.com/bazel-contrib/rules_go/releases/download/v0.58.2/rules_go-v0.58.2.zip",
"https://github.com/bazel-contrib/rules_go/releases/download/v0.58.2/rules_go-v0.58.2.zip",
],
)

load(
"@io_bazel_rules_go//go:deps.bzl",
"go_register_toolchains",
"go_rules_dependencies",
)

go_rules_dependencies()

go_register_toolchains(version = "1.25.3")

http_archive(
name = "bazelci_rules",
sha256 = "eca21884e6f66a88c358e580fd67a6b148d30ab57b1680f62a96c00f9bc6a07e",
Expand All @@ -132,15 +113,28 @@ http_archive(

load("@bazelci_rules//:rbe_repo.bzl", "rbe_preconfig")

buildifier_prebuilt_version = "8.2.0.2"

http_archive(
name = "buildifier_prebuilt",
sha256 = "f98dd3d8f32661629b8cab11f02d7730bb8e03bd8af09dbbb268047889c8ff10",
strip_prefix = "buildifier-prebuilt-{}".format(buildifier_prebuilt_version),
urls = ["http://github.com/keith/buildifier-prebuilt/archive/{}.tar.gz".format(buildifier_prebuilt_version)],
)

load("@buildifier_prebuilt//:deps.bzl", "buildifier_prebuilt_deps")

buildifier_prebuilt_deps()

load("@buildifier_prebuilt//:defs.bzl", "buildifier_prebuilt_register_toolchains")

buildifier_prebuilt_register_toolchains()

rbe_preconfig(
name = "rbe_default",
toolchain = "ubuntu2004-bazel-java11",
)

load("//scala/private/extensions:dev_deps.bzl", "dev_deps_repositories")

dev_deps_repositories()

register_toolchains("//test/toolchains:java21_toolchain_definition")

load(
Expand All @@ -152,3 +146,47 @@ load(
rules_shell_dependencies()

rules_shell_toolchains()

rules_jvm_external_version = "6.8"

http_archive(
name = "rules_jvm_external",
strip_prefix = "rules_jvm_external-%s" % rules_jvm_external_version,
sha256 = "704a0197e4e966f96993260418f2542568198490456c21814f647ae7091f56f2",
url = "https://github.com/bazelbuild/rules_jvm_external/archive/%s.zip" % rules_jvm_external_version,
)

load("@rules_jvm_external//:repositories.bzl", "rules_jvm_external_deps")

rules_jvm_external_deps()

load("@rules_jvm_external//:setup.bzl", "rules_jvm_external_setup")

rules_jvm_external_setup()

load("@rules_jvm_external//:defs.bzl", "maven_install")

maven_install(
name = "rules_scala_test_maven",
artifacts = [
"com.github.jnr:jffi:1.3.13",
"com.google.guava:guava:21.0",
"org.apache.commons:commons-lang3:3.18.0",
"org.springframework:spring-core:6.2.11",
"org.springframework:spring-tx:6.2.11",
"org.typelevel:cats-core_2.12:2.13.0",
"org.typelevel:kind-projector_2.12.20:0.13.4",
],
fetch_sources = True,
maven_install_json = "//:rules_scala_test_maven.json",
repositories = [
"https://repo.maven.apache.org/maven2",
"https://maven-central.storage-download.googleapis.com/maven2",
"https://mirror.bazel.build/repo1.maven.org/maven2",
"https://jcenter.bintray.com",
],
)

load("@rules_scala_test_maven//:defs.bzl", "pinned_maven_install")

pinned_maven_install()
2 changes: 1 addition & 1 deletion examples/twitter_scrooge/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ single_version_override(
version = "33.0",
)

bazel_dep(name = "rules_jvm_external", version = "6.7")
bazel_dep(name = "rules_jvm_external", version = "6.8")

maven = use_extension("@rules_jvm_external//:extensions.bzl", "maven")
maven.install(
Expand Down
Loading