fix(local) Add api3 targets and additional defines.

[laramiel]

Propagate defines and additional dll requirements for local python installs.

In get_local_runtime_info.py:

• detect abi3 vs. full abi libraries.
• Ensure that returned libraries are unique.
• Add additional dlls required by pythonXY.dll / pythonX.dll on windows.
• Add default defines for Py_GIL_DISABLED when the local python is a freethreaded install.
• Add defines (windows) for Py_NO_LINK_LIB to avoid #pragma comment(lib ...) macros

In local_runtime_repo_setup.bzl

• More closely match hermetic_runtime_repo_setup
• Add abi3 header targets.

In local_runtime_repo.bzl

• rework linking to local repository directories to handl abi3 and extra dlls.
• Update parameters passed into local_runtime_repo_setup.bzl

Before these changes, some blaze builds using local python fail to link properly.
This happens due to a mismatch in the interpreter and the python GIL DISABLED mode, or (on windows), where both freethreaded and non-freethreaded libraries may attempt to be linked at the same time.

[gemini-code-assist]

Summary of Changes

Hello @laramiel, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves critical linking issues encountered in Blaze builds using local Python installations. It achieves this by significantly improving the mechanism for detecting and propagating Python runtime information, including ABI flags, necessary DLLs, and specific compiler defines. These changes are particularly beneficial for Windows environments and free-threaded Python setups, ensuring that the build system correctly identifies and utilizes the appropriate Python libraries and configurations, thereby preventing linking mismatches.

Highlights

• Improved Python Library Detection: The system now more accurately detects both ABI3 and full ABI Python libraries, ensuring that the correct versions are used during linking.
• Enhanced Windows Compatibility: Additional DLLs required by Python on Windows are now properly identified and included, addressing common linking failures on this platform.
• Free-Threaded Python Support: Default defines for 'Py_GIL_DISABLED' are automatically added for free-threaded Python installations, preparing for future Python versions without the Global Interpreter Lock.
• Windows Linking Control: The 'Py_NO_LINK_LIB' define is now added on Windows to prevent automatic library linking via '#pragma comment(lib ...)' macros, providing more explicit control over the build process.
• Refactored Build Logic: The build logic in 'local_runtime_repo.bzl' and 'local_runtime_repo_setup.bzl' has been reworked to more closely match 'hermetic_runtime_repo_setup' and to properly handle ABI3 targets and extra DLLs.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the local Python runtime configuration to better support abi3 targets and handle platform-specific defines and library requirements. The changes in get_local_runtime_info.py and local_runtime_repo_setup.bzl are well-implemented, improving modularity and correctness. However, I've identified a couple of critical errors in local_runtime_repo.bzl where non-existent functions are called from repo_utils, which would lead to failures. I've also suggested a fix for an incorrect docstring. Once these issues are addressed, this PR will be a solid improvement.

[laramiel]

I'm likely to push a commit which mirrors this in tensorstore within a few hours.

Edit: The PR landed google/tensorstore@32caaba