-
-
Notifications
You must be signed in to change notification settings - Fork 638
add ci config to test 7, 8 and 9 for bcr like setup #3404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
OK, getting late, but I think this is a good start. @rickeylev, do you remember what kind of limitations we have for CI slots? |
|
There's a limit on the number of jobs. I'm not sure if its hard or soft. Looking at the recent BCR failure, i'm guess it is covering windows+bazel 8 while we're not |
| working_directory: examples/bzlmod | ||
| platform: windows | ||
| bazel: 7.x | ||
| integration_test_bzlmod_windows_upcoming: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, now I'm a bit confused.
BCR says its failing with 8.x, but this test should have been covering that (at least until the bazel 9 rc came out)?
Yet in this PR's refactored CI run, it's also giving the error BCR is giving.
The only difference seems to be the vendor step?
|
re: CI failures: I think we just need |
|
I remember @meteorcloudy suggesting that we should avoid forcing users to set this flag, because it requires Windows admin permissions. If we need to add it, then the Windows support may not work properly. I think the interesting thing is that we need this flag because we are trying to use our binary in a |
|
That's a good point and would explain what we see better. Yeah, the regular tests, which also show up as symlinks on disk (even without the enable symlinks flag), work fine I tested all the 8.x.0 versions and they all have this same issue. Bazel 7 didn't. |
|
One of the failing runs tries to run |
WIP
This is inspired by bazel-contrib/bazel-gazelle#2221. I don't have an ETA on this and will work as I have time, so feel free to add comments and what should be changed and how inf you wanna help out. :)
TODO:
Work towards #3392