Skip to content

feat(toolchain): drop 3.8 and print info level messages about it #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 20, 2025
+142 −28
Merged

feat(toolchain): drop 3.8 and print info level messages about it #3387

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
64f91a7
exp: test what breaks if we drop 3.8 from minor versions
aignas Nov 1, 2025
9b4a71a
gazelle should not have 3.8 select
aignas Nov 1, 2025
f14bea6
add warnings for the python toolchains that have been dropped
aignas Nov 4, 2025
37a9b85
Merge branch 'main' into chore/drop-3.8
aignas Nov 6, 2025
27de730
lower warn to info
aignas Nov 18, 2025
f07c7db
Merge branch 'main' into chore/drop-3.8
aignas Nov 19, 2025
c07bfea
tidy up the logic and comment for config settings
aignas Nov 19, 2025
1d8efe1
revert the gazelle change
aignas Nov 19, 2025
2fabab1
Fix wording
aignas Nov 19, 2025
c0d1d65
only add compatibility values for 3.8 and above
aignas Nov 19, 2025
a8ed451
add a test
aignas Nov 19, 2025
4e2cac0
comment: split lines
aignas Nov 20, 2025
a36758a
comment: rename to fail_on_err
aignas Nov 20, 2025
8be6135
make the style the same
aignas Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions python/versions.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,6 @@ DEFAULT_RELEASE_BASE_URL = "https://github.com/astral-sh/python-build-standalone
#
# buildifier: disable=unsorted-dict-items
TOOL_VERSIONS = {
"3.8.20": {
"url": "20241002/cpython-{python_version}+20241002-{platform}-{build}.tar.gz",
"sha256": {
"aarch64-apple-darwin": "2ddfc04bdb3e240f30fb782fa1deec6323799d0e857e0b63fa299218658fd3d4",
"aarch64-unknown-linux-gnu": "9d8798f9e79e0fc0f36fcb95bfa28a1023407d51a8ea5944b4da711f1f75f1ed",
"x86_64-apple-darwin": "68d060cd373255d2ca5b8b3441363d5aa7cc45b0c11bbccf52b1717c2b5aa8bb",
"x86_64-pc-windows-msvc": "41b6709fec9c56419b7de1940d1f87fa62045aff81734480672dcb807eedc47e",
"x86_64-unknown-linux-gnu": "285e141c36f88b2e9357654c5f77d1f8fb29cc25132698fe35bb30d787f38e87",
},
"strip_prefix": "python",
},
"3.9.10": {
"url": "20220227/cpython-{python_version}+20220227-{platform}-{build}.tar.gz",
"sha256": {
Expand Down Expand Up @@ -1011,7 +1000,6 @@ TOOL_VERSIONS = {

# buildifier: disable=unsorted-dict-items
MINOR_MAPPING = {
"3.8": "3.8.20",
"3.9": "3.9.24",
"3.10": "3.10.19",
"3.11": "3.11.14",
Expand Down