-
-
Notifications
You must be signed in to change notification settings - Fork 4
Patches #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I think if we go this route, we should make it a first class citizen in the README (and the docs) on how to actually do a patch correctly. I'm not a huge fan of patches because the patches themselves are not human readable. In this case it works becuase the output is human readable: the resulting mdx file. |
|
What I mean by human readable is: they are not the easiest thing to grok for the untrained eye. |
|
If we allow patches, I imagine the script would actually diff the upstream/ submodule against origin, and update all the patches for you, like https://github.com/ds300/patch-package But this example with a isn't a great motivation since it's not that hard to automate this translation. I'm fine not merging this and we can discuss more. |
Allow a controlled way for content on the site to diverge from bazelbuild/bazel repo.
This relaxes how complete our translation from Jekyll and HTML needs to be. In this example I manually fix a
<table>tag, which means we don't have to create an automated replacement.The size of the patch file makes it obvious whether we are diverging too much, versus a fork of the repo where the git history hides the delta from upstream.
Issues: