Switch React.PropTypes to PropTypes package #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, can anyone merge this PR? Please. @bgryszko |
|
Plz just merge this and release |
andrew-nguyen
added a commit
to andrew-nguyen/react-native-circular-slider
that referenced
this pull request
Jun 11, 2018
ghost
mentioned this pull request
|
is this going to ever be merged..? |
arvindebiztrait
approved these changes
Nov 30, 2018
|
Any update on these changes getting merged? I am unable to use this library due to proptypes error |
|
Merge to master, please. |
|
in the meantime it is possible to solve this way:
or with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React.PropTypes was deprecated in React 15.x and removed from the core package in React 16.
This PR switches the implementation to use the PropTypes package, as instructed.
The change has been tested and I've also included a version bump commit for ease of publishing to npm.