update esbuild to 0.17.5 with new watch mode support #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinguet62
approved these changes
Feb 10, 2023
lmiller1990
approved these changes
Feb 15, 2023
lmiller1990
left a comment
lmiller1990
left a comment
There was a problem hiding this comment.
Nice, I tested, works great! Maybe cc @bahmutov
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
FYI, this change is causing badeball/cypress-cucumber-preprocessor#1247. It appears that the promise returned from |
3 tasks
Owner
|
Mind opening a pull request to fix thisSent from my iPhoneOn Nov 2, 2025, at 15:06, Jonas Amundsen ***@***.***> wrote:badeball left a comment (bahmutov/cypress-esbuild-preprocessor#245)
FYI, this changed is causing badeball/cypress-cucumber-preprocessor#1247. It appears the promise returned from esbuild.context(..) resolves before any file has actually been written to outputPath, which is in violation of the preprocessor API.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Contributor
|
Sure, I've created #515. FYI, I wish this had a test suite, but creating one is far more than I'm willing to contribute now. Edit: unit tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to tackle #229 I created this little PR.