fixed jshint

Author: bahmutov

expensive-keys.js

@@ -13,11 +13,11 @@
     return function (object) {
       return object[key];
     };
-  }
+  };
 
   var pickValue = function (key, items) {
     return items.map(value(key));
-  }
+  };
 
   function keySize(items, key) {
     return stringSize(key) * items.length + objectSize(pickValue(key, items));

first-paint.js

@@ -1,5 +1,6 @@
 // taken from https://www.youtube.com/watch?v=S9sktFzL3tQ
 (function timeFirstPaint() {
+  /* global chrome */
   var fp = chrome.loadTimes().firstPaintTime - chrome.loadTimes().startLoadTime;
   console.log('first paint: ' + fp);
 }());

local-storage-size.js

@@ -13,7 +13,7 @@
     return {
       name: key,
       size: stringSizeBytes(localStorage[key])
-    }
+    };
   }
 
   function toSizeMB(info) {

ng-count-watchers.js

@@ -8,8 +8,9 @@
 
     // go through each element. Count watchers if it has scope or isolate scope
     for (i=0; i < len; i++) {
+        /* global angular */
         data = angular.element(all[i]).data();
-        var scope = data.$scope || data.$isolateScope;
+        scope = data.$scope || data.$isolateScope;
         if (scope && scope.$$watchers) {
             if ( ! test[ scope.$id ] ) {
                 test[ scope.$id ] = true;

ng-find-expensive-digest.js

@@ -1,22 +1,30 @@
 // assumes profileDirectiveDigest(selector)
 // use: findExpensiveDigest(selector1, selector2, ...);
-function findExpensiveDigest() {
-  if (typeof findExpensiveDigest !== 'function') {
-    throw new Error('cannot find findExpensiveDigest function');
+
+/* global profileDirectiveDigest */
+(function (window) {
+
+  function findExpensiveDigest() {
+    if (typeof profileDirectiveDigest !== 'function') {
+      throw new Error('cannot find profileDirectiveDigest function');
+    }
+    var selectors = Array.prototype.slice.call(arguments, 0);
+    var durations = selectors.map(function timeSelectorDigest(selector) {
+      /* global performance */
+      var started = performance.now();
+      profileDirectiveDigest(selector);
+      var takes = performance.now() - started;
+      return takes;
+    });
+    var merged = selectors.map(function (selector, k) {
+      return { selector: selector, takes: durations[k] };
+    });
+    merged = merged.sort(function (a, b) {
+      return b.takes - a.takes;
+    });
+    console.log('elements with expensive digest cycles');
+    console.table(merged);
   }
-  var selectors = Array.prototype.slice.call(arguments, 0);
-  var durations = selectors.map(function timeSelectorDigest(selector) {
-    var started = performance.now();
-    profileDirectiveDigest(selector);
-    var takes = performance.now() - started;
-    return takes;
-  });
-  var merged = selectors.map(function (selector, k) {
-    return { selector: selector, takes: durations[k] };
-  });
-  merged = merged.sort(function (a, b) {
-    return b.takes - a.takes;
-  });
-  console.log('elements with expensive digest cycles');
-  console.table(merged);
-}
+
+  window.findExpensiveDigest = findExpensiveDigest;
+}(window));

ng-scope-size.js

@@ -10,8 +10,9 @@
 
     // go through each element. Count watchers if it has scope or isolate scope
     for (i=0; i < len; i++) {
+        /* global angular */
         data = angular.element(all[i]).data();
-        var scope = data.$scope || data.$isolateScope;
+        scope = data.$scope || data.$isolateScope;
         if (scope) {
             if ( ! test[ scope.$id ] ) {
                 test[ scope.$id ] = true;
@@ -46,7 +47,7 @@
     for (var index = 0; index < objects.length; index ++){
 
       // determine the type of the object
-      switch (typeof objects[index]){
+      switch (typeof objects[index]) {
 
         // the object is a boolean
         case 'boolean': size += 4; break;
@@ -62,11 +63,16 @@
 
           // loop over the keys
           for (var key in objects[index]) {
-            if (key[0] === '$' || key === 'this' || key === 'constructor' || key === 'lenth')
+            if (!objects[index].hasOwnProperty(key)) {
+              continue;
+            }
+            if (key[0] === '$' || key === 'this' || key === 'constructor' || key === 'lenth') {
               continue; // angular's internal property ($apply, etc)
+            }
 
             // determine whether the value has already been processed
             var processed = false;
+            /* jshint -W073 */
             for (var search = 0; search < objects.length; search ++){
               if (objects[search] === objects[index][key]){
                 processed = true;
@@ -75,7 +81,9 @@
             }
 
             // queue the value to be processed if appropriate
-            if (!processed) objects.push(objects[index][key]);
+            if (!processed) {
+              objects.push(objects[index][key]);
+            }
 
           }