fixed some jshint issues

Author: bahmutov

Gruntfile.js

@@ -2,7 +2,8 @@ module.exports = function(grunt) {
   'use strict';
 
   var sourceFiles = [
-    '*.js', '!Gruntfile.js'
+    '*.js', '!Gruntfile.js',
+    '!timing.js' // based on 3rd party script
   ];
 
   grunt.initConfig({
@@ -20,7 +21,8 @@ module.exports = function(grunt) {
     jshint: {
       all: sourceFiles,
       options: {
-        jshintrc: '.jshintrc'
+        jshintrc: '.jshintrc',
+        reporter: require('jshint-summary')
       }
     },
 

ng-find-scope-property.js

@@ -1,25 +1,31 @@
 // finds all properties with given name attached to the scopes
-function findScopeProperty(name) {
-    var i, data, scope,
-        all = document.all,
-        len = all.length,
-        test = {};
-    var found = [];
+(function (window) {
 
-    for (i=0; i < len; i++) {
-        data = angular.element(all[i]).data();
-        var scope = data.$scope || data.$isolateScope;
-        if (scope && scope.hasOwnProperty(name)) {
-            if ( ! test[ scope.$id ] ) {
-                test[ scope.$id ] = true;
-                found.push(scope);
+    function findScopeProperty(name) {
+        var i, data, scope,
+            all = document.all,
+            len = all.length,
+            test = {};
+        var found = [];
+
+        /* global angular */
+        for (i=0; i < len; i++) {
+            data = angular.element(all[i]).data();
+            scope = data.$scope || data.$isolateScope;
+            if (scope && scope.hasOwnProperty(name)) {
+                if ( ! test[ scope.$id ] ) {
+                    test[ scope.$id ] = true;
+                    found.push(scope);
+                }
             }
         }
+        if (!found.length) {
+          console.log('could not find any scopes with', name, 'property');
+        } else {
+          console.log('found', found.length, 'scopes with property', name);
+        }
+        return found;
     }
-    if (!found.length) {
-      console.log('could not find any scopes with', name, 'property');
-    } else {
-      console.log('found', found.length, 'scopes with property', name);
-    }
-    return found;
-}
+
+    window.findScopeProperty = findScopeProperty;
+}(window));

ng-idle-apply-timing.js

@@ -2,6 +2,8 @@
 // More watchers - longer cycle
 // More complicated expression logic - longer cycle
 // Also creates CPU profile for debugging bottlenecks (Chrome DevTools)
+
+/* global angular, performance */
 angular.element(document).injector().invoke(function timeApply($rootScope) {
   console.profile('$apply');
   var started = performance.now();

ng-profile-data-change.js

@@ -7,13 +7,13 @@
   var propertyName = 'selectedBenchmarks';
   var name = selector + ':' + propertyName;
 
+  /* global angular */
   var el = angular.element(selector);
   var scope = el.scope() || el.isolateScope();
   console.assert(scope, 'cannot find scope from ' + name);
 
   var property = scope[propertyName];
   console.assert(property, 'missing ' + name);
-  var $timeout = el.injector().get('$timeout');
 
   function digestCycle() {
     angular.element(document).injector().get('$rootScope').$apply();

ng-profile-local-digest.js

@@ -3,16 +3,21 @@ dirty checking watchers) takes for a scope surrounding given selector.
 Use: run this code snippet, then profileDirectiveDigest('#foo'); to measure
 watchers in the #foo element (and its children along the scope tree).
 */
-function profileDirectiveDigest(selector) {
-  console.assert(selector && typeof selector === 'string', 'expected selector', selector);
-  var el = document.querySelector(selector);
-  console.assert(el, 'cannot find element with selector', selector);
+(function (window) {
 
-  /* global angular */
-  var ngEl = angular.element(el);
-  var scope = ngEl.scope() || ngEl.isolateScope();
-  console.assert(scope, 'cannot find scope from element', selector);
-  console.time(selector + ' digest');
-  scope.$digest();
-  console.timeEnd(selector + ' digest');
-}
+  function profileDirectiveDigest(selector) {
+    console.assert(selector && typeof selector === 'string', 'expected selector', selector);
+    var el = document.querySelector(selector);
+    console.assert(el, 'cannot find element with selector', selector);
+
+    /* global angular */
+    var ngEl = angular.element(el);
+    var scope = ngEl.scope() || ngEl.isolateScope();
+    console.assert(scope, 'cannot find scope from element', selector);
+    console.time(selector + ' digest');
+    scope.$digest();
+    console.timeEnd(selector + ' digest');
+  }
+
+  window.profileDirectiveDigest = profileDirectiveDigest;
+}(window));

package.json

@@ -18,6 +18,7 @@
     "grunt-jscs": "1.0.0",
     "grunt-nice-package": "0.9.2",
     "grunt-npm2bower-sync": "0.4.0",
+    "jshint-summary": "0.4.0",
     "matchdep": "0.3.0",
     "pre-git": "0.1.1"
   },