-
-
Notifications
You must be signed in to change notification settings - Fork 115
Support form submission from buttons and inputs outside form using form attribute #1771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
644007c
Initial plan
Copilot fc32443
Initial investigation of form submit issue
Copilot ff0de7b
Implement support for clicking submit button outside form with form a…
Copilot 8c440c2
Improve comments in FindFormById method
Copilot 150e5df
Restore net10.0 target framework to all projects
Copilot 32d7373
Fix misleading comment about incremental DOM rendering
Copilot 36a5d18
Add test cases for input element with form attribute outside form
Copilot 29cbd3d
Simplify FindFormById by removing GetElementById attempt
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
tests/bunit.testassets/SampleComponents/FormWithSubmitElementsOutside.razor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <form @onsubmit="Callback" id="form1"> | ||
| </form> | ||
| <button type="submit" form="form1" id="submit-button">Submit Button</button> | ||
| <input type="submit" form="form1" id="submit-input" value="Submit Input" /> | ||
|
|
||
| @code { | ||
| public bool SubmitWasCalled { get; private set; } | ||
|
|
||
| private void Callback() | ||
| { | ||
| SubmitWasCalled = true; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the HTML standard allow for an tag to be used in this scenario? If so, also add a test case for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the HTML5 standard allows
<input type="submit">with theformattribute. Added test cases in commit 36a5d18 for both button and input elements outside forms using the form attribute.