test: create clicking on submit button outside triggers onsubmit of form #1770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
11 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds test coverage for form submission behavior when a submit button is located outside the form element but associated via the HTML5 form attribute. The changes clean up whitespace inconsistencies and add a new test case to verify this specific scenario.
- Normalized line endings and removed trailing whitespace in existing test methods
- Added a new test
ClickingOnSubmitButtonOutsideTriggersOnsubmitOfFormto verify submit buttons outside forms work correctly - Created a new test component
FormWithButtonOutside.razorto support the new test case
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/bunit.tests/EventDispatchExtensions/FormDispatchExtensionTest.cs | Added new test case for external submit button and cleaned up whitespace |
| tests/bunit.testassets/SampleComponents/FormWithButtonOutside.razor | New test component with a form and an external submit button linked via form attribute |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ing form attribute (#1771) * Initial plan * Initial investigation of form submit issue Co-authored-by: egil <105649+egil@users.noreply.github.com> * Implement support for clicking submit button outside form with form attribute Co-authored-by: egil <105649+egil@users.noreply.github.com> * Improve comments in FindFormById method Co-authored-by: egil <105649+egil@users.noreply.github.com> * Restore net10.0 target framework to all projects Co-authored-by: linkdotnet <26365461+linkdotnet@users.noreply.github.com> * Fix misleading comment about incremental DOM rendering Co-authored-by: egil <105649+egil@users.noreply.github.com> * Add test cases for input element with form attribute outside form Co-authored-by: egil <105649+egil@users.noreply.github.com> * Simplify FindFormById by removing GetElementById attempt Co-authored-by: egil <105649+egil@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: egil <105649+egil@users.noreply.github.com> Co-authored-by: linkdotnet <26365461+linkdotnet@users.noreply.github.com>
Member
Author
|
@copilot update the changelog.md accordingly |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.