Skip to content

fix(grpcgen): remove ambiguous message about missing --file when using compilation database #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(grpcgen): remove ambiguous message about missing --file when using compilation database #23

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72a5e99
fix(grpcgen): remove ambiguous message about missing --file when usin…
jim-bcom Feb 16, 2024
fafb0bb
fix: make proper assert about --file/--database_dir mutual exclusivity
jim-bcom Feb 16, 2024
bc064b5
fix: update "missing file" message and remove mutual exclusion change
jim-bcom Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/generators/grpc/xpcf_grpc_gen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ try

if (!options.count("file") || options["file"].as<std::string>().empty()) {
if (options.count("database_dir") && !options["database_dir"].as<std::string>().empty()) {
std::cout<<"File argument is missing : parsing every file listed in database"<<std::endl;
std::cout<<"--file is not set : parsing every file listed in database"<<std::endl;
astParser->parse_database(options["database_dir"].as<std::string>(),options);
//parse_database(options["database_dir"].as<std::string>(),idx,options, [&](const cppast::cpp_entity_index& idx, std::ostream& out, const cppast::cpp_file& file) { astParser->parseAst(idx,out,file); });
}
Expand Down