Add support for exposing ECS task metadata as Spring properties #1485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@maciejwalkowiak Looks like the (automatically issued) PR label is wrong, this isn't a dependency upgrade. |
jpalomaki
changed the title
jpalomaki
force-pushed
the
ecs-metadata
branch
from
c60016d to
6194fd4
Compare
maciejwalkowiak
requested changes
Oct 30, 2025
Contributor
maciejwalkowiak
left a comment
maciejwalkowiak
left a comment
There was a problem hiding this comment.
Thanks @jpalomaki and apologies for late reply. It got out of sync with main and i left few comments.
Before we can merge it, we definitely need tests.
| * @since 3.5.0 | ||
| */ | ||
| @AutoConfiguration | ||
| @ConditionalOnProperty(name = "spring.cloud.aws.ecs-task-metadata.enabled", havingValue = "true", matchIfMissing = false) |
Contributor
There was a problem hiding this comment.
Perhaps it should be disabled by default? It will add some time to startup so it should be an opt-in feature.
| @@ -0,0 +1,23 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Contributor
There was a problem hiding this comment.
Is there a need for starter considering it does not bring any extra dependencies?
maciejwalkowiak
added
type: feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Implements support for fetching AWS ECS task metadata (e.g.
TaskARN) from the standard ECS metadata endpoint v4, and exposing that metadata as properties in the Spring environment, for use e.g. in logs or OTEL metadata.💡 Motivation and Context
Fixes #1477
💚 How did you test it?
TBD
📝 Checklist
🔮 Next steps
TBD